CON-1152 - jQuery Upgrade in Umbraco Core 7.5 + breaks UI & functionality of Contour

Created by Warren Buckley 24 Aug 2016, 08:57:23 Updated by Sebastiaan Janssen 27 Sep 2016, 17:25:32

jQuery has been upgraded in the Umbraco Core codebase in 7.5 and greater, which has broken functionality of Contour due to deprecated methods in jQuery such as .live()

Investigating if dropping in jQuery-migrate library will help resolve all the issues currently

1 Attachments

Download umbracoforms.js

Comments

Warren Buckley 24 Aug 2016, 13:37:30

A PR for this has been submitted for review here - https://github.com/umbraco/Forms/pull/90

Test Notes

  • Use CreatePackage.bat in build folder to create package outputs (As debugging directly in SLN still painful)
  • Ensure you see no console errors when using this build of Contour with Umbraco 7.5+
  • Test this works with pre Umbraco 7.5.x (before we changed jQuery lib in core)


Sebastiaan Janssen 24 Aug 2016, 14:11:59

Added some quick notes to the PR! :) Didn't test the functionality by the way, so that will still need a review after fixing this up.


Warren Buckley 25 Aug 2016, 13:22:51

Updated the PR @sebastiaan now with a local copy of the jQuery migrate library as opposed to the jQuery hosted CDN file


James South 08 Sep 2016, 01:16:10

Why not fix the code that needs to be migrated? The jQuery team are very careful when it comes to backwards compatibility.


Warren Buckley 08 Sep 2016, 08:22:25

I can't do that as I have no guarantee of what version of Umbraco Contour is installed into. If it's before 7.5 then we would have an older copy of jQuery and if I update those methods to use the new jQuery library then older versions of Umbraco using contour would break.

So its for backwards compat reasons.


Mike 09 Sep 2016, 06:39:55

Hi all,

I've added several fixes, which works for me.

Also you can update simplemodel to latest https://code.google.com/archive/p/simplemodal/downloads.

Please check.


Priority: Normal

Type: Bug

State: Fixed

Assignee:

Difficulty:

Category:

Backwards Compatible: True

Fix Submitted:

Affected versions: 3.0.29

Due in version:

Sprint: Sprint 43

Story Points:

Cycle: