CON-1268 - "Send Mail" Workflow not active, but e-mail is still sent.

Created by Cristiano Martins 22 Feb 2017, 13:14:43 Updated by Patrick Schalkwijk 22 Feb 2018, 13:27:52

Tags: Gold partner

Subtask of: CON-1390

Your report will have a greater chance of being addressed if you can give us clear steps to reproduce the issue, please answer the following questions in as much detail as possible: What did you do? Created a new "Send Mail" Workflow, e-mail was sent with success, now I need to disable this workflow so I unchecked the "Active" field inside the workflow. What did you expect to happen? I expect the e-mail to not be sent anymore, when the user fills this form. What actually happened? The e-mail is still being sent What version of Umbraco are you using? 7.5.3 assembly: 1.0.6092.24019 What version of Umbraco Forms or Contour are you using? Umbraco Forms: "4.4.0"

2 Attachments

Comments

William Cowie 16 Mar 2017, 09:52:25

Have also replicated this issue the flag is being set correctly in the workflows (\App_Plugins\UmbracoForms\Data\workflows) but not being triggered


Matthew 16 Jun 2017, 14:38:03

This also doesn't work for the Send Email with Template workflow in Umbraco Forms 6.0.1


Marcel Hogenstein 10 Jan 2018, 16:12:33

I can confirm that this issue still persists in version 6.0.6 for the SendRazorEmail workflow. The workflow is executed regardless of the active (or not) switch.

A Major issue to me as, apart from removing the workflow from the configuration, there is no way to (temporarily) disable a workflow.


Marcel Hogenstein 18 Jan 2018, 09:40:24

When using dotPeek it appears to me that, despite the method name GetActiveWorkflows, all workflows are retrieved instead of the active:

public List GetActiveWorkFlows(Form form, FormState state) { List workflowList = new List(); foreach (Guid workflowId in form.WorkflowIds) { Workflow workflow = this.GetWorkflow(workflowId); if (workflow != null && workflow.ExecutesOn == state) workflowList.Add(workflow); } return workflowList; }


Patrick Schalkwijk 22 Feb 2018, 08:42:41

This issue is also in Umbraco Cloud environment (Umbraco version 7.8.1 assembly: 1.0.6614.16975, Umbraco Forms: "6.0.6"). Now that errors are shown in the Portal, it's a big mess of useless errors. All the Umbraco Forms that are submitted are sending out emails even when the active checkbox is off. Because we do not want the forms to be send out by email, we had to add a false to emailaddress. This gives an error and the error logs are showing all these SendRazorEmail Errors.

07:31:00.361 ERROR Umbraco.Forms.Core.Providers.WorkflowTypes.SendRazorEmail There was a problem sending a Razor email to 'website@lvnl.nl' from Workflow for Form 'Registration' with id 'xxxxxxxx-xxxx-xxxx-xxxx-xxxxxxxxxxxx' for Record with unique id 'xxxxxxxx-xxxx-xxxx


Sebastiaan Janssen 22 Feb 2018, 11:06:00

@pschalkwijk@findigit.net You can also just remove the workflow from the form if you don't want to send emails. :)


Patrick Schalkwijk 22 Feb 2018, 13:11:44

@sebastiaan Too bad...that is not possible with that standard step


Patrick Schalkwijk 22 Feb 2018, 13:14:50

just like the message or redirect step in the workflow, email cannot be removed. Or is there another way to do this.


Sebastiaan Janssen 22 Feb 2018, 13:22:18

@pschalkwijk@findigit.net Your styling looks a bit messed up, but I think the floating recycle bin under it will do the trick for you.


Patrick Schalkwijk 22 Feb 2018, 13:27:52

@sebastiaan Aha...Internet Explorer... Thank you!


Priority: Major

Type: Bug

State: Fixed

Assignee:

Difficulty:

Category:

Backwards Compatible: True

Fix Submitted:

Affected versions: 6.0.1, 6.0.2, 6.0.3, 6.0.4, 6.0.6

Due in version: 6.0.7

Sprint: Sprint 79

Story Points: 1

Cycle: 8