CON-1523 - Upgrading Umbraco while there is also a Forms upgrade pending leads to loads of app pool restarts

Created by Sebastiaan Janssen 17 Apr 2018, 07:45:41 Updated by Claus Jensen 25 Apr 2018, 10:54:13

Tags: Unscheduled

When both Umbraco and Forms are being upgraded (mostly happens on Cloud), Forms keeps bumping the version ClientDependency.config a lot, so you get a lot of recycles and the upgrade takes forever to finish.

This is due to the fact that after Umbraco updates the version, the app pool recycles and then on PreAppInit Forms kicks in and thinks it needs to bump the version too. When the app pool has been recycled, Umbraco kicks in again and changes the version, then Forms etc. etc.

The problem started when we changed the CDF logic in Umbraco 7.9 (coinciding with the release of Forms 7.0.0).

Comments

Sebastiaan Janssen 17 Apr 2018, 07:53:46

PR https://github.com/umbraco/Forms/pull/185


Sebastiaan Janssen 17 Apr 2018, 07:58:33

To test, either take a Cloud site which has had upgrades to both Forms 7 AND Umbraco 7.9+ and clone it locally. Run the site and observer that the version in ClientDependency.config keeps changing and the upgrade installer loads for a looooong time. If you don't have a setup like that, install Umbraco 7.8.x, install Forms 6 latest in it, then drop in both the upgdated Umbraco dlls and the updated Forms dlls (version 7.0.1!) at the same time. This should cause the same behavior.

After updating to the new Forms dlls from this PR, you should see that the Umbraco upgrade installer loads quickly as usual. Of course make sure to verify afterwards that both Forms and Umbraco have been upgraded and watch the CDF version number for changes, it should only change twice in this process.


Robert Copilau 18 Apr 2018, 14:20:43

Awesome, this seems to have fixed the slowness :D, merged!


Priority: Major

Type: Bug

State: Fixed

Assignee:

Difficulty:

Category:

Backwards Compatible: False

Fix Submitted:

Affected versions: 7.0.0, 7.0.1

Due in version: 7.0.2

Sprint: Sprint 83

Story Points: 1

Cycle: 9