CON-934 - Can't create datasources or prevalue sources

Created by Bjarne Fyrstenborg 12 Mar 2016, 16:24:30 Updated by Warren Buckley 31 Aug 2017, 07:56:41

Tags: Unscheduled

Is duplicated by: CON-1007

I have installed v. 4.2.1 in a Umbraco 7.4.1 install using SQL CE. But when I create a new datasource or prevalue source, nothing seems to happen - I just get a blank area to the right?

1 Attachments

Comments

Warren Buckley 13 Mar 2016, 22:01:11

Hi @Bjarne.Fyrstenborg Can you clear your browser cache for me please as a starting point please & retry this.

Can you verify your user in Users section in the Forms Security tree has the correct permissions to create custom DataSource or custom PreValues.

If not can you help me with some further information on steps on how I can reproduce this please.

Many Thanks, Warren


Bjarne Fyrstenborg 13 Mar 2016, 22:28:07

Hi @warren.buckley The browser cache is cleared and the backoffice user is Administrator and have all permissions set.


Warren Buckley 16 Mar 2016, 08:26:59

@Bjarne.Fyrstenborg are you able to re-test this for me please with your site in Debug mode so that ClientDependency is not being used. So if we can see if it's something unusual happening there and report back please :)


Tom 16 Mar 2016, 11:41:30

Hey @warren.buckley

I'm also experiencing the same issue on two different Umbraco instances, both were fresh installs of Umbraco Forms 4.2.1 from NuGet. I've tried clearing my browser cache, bumping ClientDependency and running in debug mode but get the same issue (blank white right panel). I've checked the browser console and umbraco logs and no errors are getting outputted.

Thanks, Tom


Tom 16 Mar 2016, 12:04:39

@warren.buckley A colleague has just been having a dig around and it looks like it is related to the following check in the angular view: security.userSecurity.managePreValueSources

ng-show="loaded && security.userSecurity.managePreValueSources"


Warren Buckley 16 Mar 2016, 12:09:09

Thanks @tommyflintsteer this is something that got slipped through the net when this went into internal testing & review when the Security stuff was added.

Yes as a temporary workaround you can modify the HTML view on disk to ng-show="loaded" I will mark this as open and look at this tomorrow, so a nightly can get resolved until 4.2.2 is released


Bjarne Fyrstenborg 16 Mar 2016, 21:12:43

Hi @warren.buckley

yes, it works if I remove "security.userSecurity.manageDataSources" in ng-show for edit.html for datasources and prevalue sources.

However it also seems that sometimes don't get the create action for datasources - but I can access it by requesting /umbraco/#/forms/datasource/edit/-1?create

I do have the create action for "forms" and "prevalue source". I wonder if it has something to do with the security settings?


Bjarne Fyrstenborg 16 Mar 2016, 21:14:59

Okay, somehow "Manage Data Sources" wasn't checked in Users -> Form Security. Users of type "Administrator" get by default permission to all, right? :)


Warren Buckley 16 Mar 2016, 21:18:04

Hi @Bjarne.Fyrstenborg & @tommyflintsteer I am able to replicate the issue. Sorry this one slipped through the net especially as I had someone code review it, apologies.

I know how to resolve this & will do this in the morning & get it re-tested here with the team, once approved it will be available as a nightly build that you can use.

In regards to default settings, yes you should have access to all, if you feel this is an issue Bjarne & can replicate in a clean install then please can you log a new issue.


Bjarne Fyrstenborg 16 Mar 2016, 21:55:57

Okay, I will let you know if I see this in future installs.


Paul Wright 22 Mar 2016, 11:33:31

Getting same problem, Fresh install of 7.4.2 on MS SQL, and clicked "install Umbraco forms".

Ensured forms security settings are correct for current user. (admininistrator, and everything ticked in forms security)

This issue needs fixing ASAP, as it essentially leaves Umbraco forms totally uselesss


Warren Buckley 22 Mar 2016, 11:52:23

Hi @suedeapple this is fixed and waiting for internal review, I have asked the team to see if it can get looked at sooner, as once the PR is merged I can offer a nightly build to rectify this.

But if you require an immediate workaround, you can modify the two views for this which is essentially hiding the UI based on the new security settings.

App_Plugins/UmbracoForms/BackOffice/DataSource/Edit.html

Amend the ng-show from ng-show="loaded && security.userSecurity.manageDataSources"

to the following ng-show="loaded"

The fix in the PR that is getting reviewed, will continue to work with the security check, but this gives you an immediate workaround for this bug. Sorry for the inconvenience @suedeapple


Paul Wright 22 Mar 2016, 12:01:53

@warren.buckley cool - seems to work. At least enough to let me carry on with the grafting :-)

Spotted a couple more minor issues with Umb Forms, will post up when I get chance.


Warren Buckley 22 Mar 2016, 12:03:00

Yes please check the issue tracker to see if the issue does not already exist, if so vote it up, otherwise yes I would love for you to add items to the tracker.

Thanks, Warren :)


Stephan 22 Mar 2016, 12:28:54

merged.


Warren Buckley 23 Mar 2016, 09:33:15

@suedeapple & any others after this got merged in yesterday the build server has built a new nightly with this fix in 4.2.2 Build 131

If you do wish to update to a nightly as with anything ensure you backup everything in case you need to roll back if you wish to do so, but the nightly files can be found here: http://nightly.umbraco.org/?container=umbraco-forms

ZIP that you can unpack over the top of your site https://umbraconightlies.blob.core.windows.net/umbraco-forms/nightlies/UmbracoForms.Files.4.2.2-build131.zip

Umbraco Package https://umbraconightlies.blob.core.windows.net/umbraco-forms/nightlies/UmbracoForms.Package.4.2.2-build131.zip

Nuget Packages https://umbraconightlies.blob.core.windows.net/umbraco-forms/nightlies/UmbracoForms.4.2.2-build131.nupkg https://umbraconightlies.blob.core.windows.net/umbraco-forms/nightlies/UmbracoForms.Core.4.2.2-build131.nupkg


Hassan 10 May 2016, 08:29:17

@Warren Buckley Hi. I want to update Umbraco Forms 4.2.1 to nighty UmbracoForms.Package.4.2.2-build131. What happend to exits form on current version after i will update to new version? Will they stay on my project or delete?


Warren Buckley 10 May 2016, 08:37:44

Hi @hassan When updating to any nightly you are running on bleeding edge code, so as always please ensure you have a backup of your site & database so that it can be rolled back easily if the upgrade does not work.

I would recommend you use the zip titled Files and unzip this over the top of your site at the root.

Thanks, Warren


Hassan 14 May 2016, 07:46:04

Hi @Warren Buckley I updated umbraco forms 4.2.1 to nighty UmbracoForms.Package.4.2.2-build13, but it did not help me! Forms were created, but they were not saved.So they are Useless. I want to downgrade to 4.1.5. If I downgrade umbraco forms 4.2.1 to 4.1.5, what will happen to my data? Will my form's data delete or not? Is there any way to keep data in this downgrade ?


Warren Buckley 17 May 2016, 07:33:18

Hi @hassan To answer your question ensure you make a backup of your site, files & DB then try a downgrade in the meantime whilst you wait for a 4.3.0 release.


Hassan 17 May 2016, 07:41:43

@Warren Buckley I am waiting for 4.3.0 Thanks for your reply and Guidance. With the best wishes for you and Umbraco team.


Priority: Major

Type: Bug

State: Fixed

Assignee:

Difficulty:

Category:

Backwards Compatible: True

Fix Submitted:

Affected versions: 4.2.1

Due in version: 4.3.0

Sprint: Sprint 11

Story Points:

Cycle: