Click here to create a new issue on GitHub

CON-959 - WorkflowType.Workflow is Null

Created by Nick Frederiksen 04 Apr 2016, 13:38:33 Updated by Danny Summers 12 Aug 2016, 05:42:48

I am working on a retry strategy for custom workflow types, and must therefore register the failing form, record, workflow type and workflow. But, I am not able to get the Workflow from the workflow type.

The WorkflowType class, do have a property called "Workflow". This, however, is null, unless I make a call to the LoadSettings-method. Which takes the workflow, i do not have, as a parameter.

I have a better description of my problem on our: https://our.umbraco.org/forum/umbraco-forms//76328-get-current-workflow-from-workflowtypeexecute-method

Did some digging, turns out the WorkflowService.ExecuteWorkflows(List workflows, RecordEventArgs e) - method, has the same logic for loading settings, as WorkflowType.LoadSettings, but does not call the latter.

Comments

Warren Buckley 24 May 2016, 13:12:42

This is ready for review in this PR here - https://github.com/umbraco/Forms/pull/58

Test notes

  • Attach debugger to a workflow type that is used in a form submission, Email is probably a good one, as it's the default. Attch it to the Excute function/method
  • When inside the execute function ensure the property Workflow is populated & contains things like ID, Workflow Name & so on

Priority: Normal

Type: Bug

State: Fixed

Assignee:

Difficulty:

Category:

Backwards Compatible: True

Fix Submitted:

Affected versions: 4.2.1

Due in version: 4.3.0

Sprint: Sprint 16

Story Points:

Cycle: