COU-505 - Add Button does not work in Revisions

Created by Jim Jensen 20 Jan 2017, 13:30:02 Updated by Shannon Deminick 27 Apr 2017, 22:14:57

Tags: Unscheduled Gold partner

Relates to: COU-540

Subtask of: COU-521

Umbraco 7.5.7 Courier 3.0.3 Fresh install.

What happens: When creating a new revision and wants to decide items to transfer in that revision, then clicking the Add buttons does not react. There is no dialogue box opening when clicking.

What expected to happen: Dialogue box (some media/content picker) should open so you can choose what items to add to the revision.

1 Attachments

Comments

Yoeri Van de Moortel 24 Jan 2017, 12:12:04

EditLocalRevision.aspx checks on currentManifest.Providers.length, this crashes when currentManifest.Providers is underfined.

I currently fixed it by adding a check ... {code:lang=javascript|title=check on line 73} if(currentManifes.Providers && currentManifest.Providers.length > 0)

After this fix, the dialog appears ... selection is possible in Chrome (Some dynatree issues in Firefox?)


Shola 01 Feb 2017, 18:20:33

I'm experiencing this as well, with 7.5.7 and Courier 3.0.3. However, I wonder if there are any dangers in the above fix?


David Twamley 02 Feb 2017, 18:49:02

Line 21 var currentManifest = <%= ManifestJson %>; is giving var currentManifest = {"id":"bd3c7096-3bf6-4488-b9b7-73c7de040dc8","providers":[]};. Notice the difference in case on providers. That's coming out of Umbraco.Courier.UI.dll and it makes me think the model and the pages have gotten way out of sync. I did attempt a fix with a replace of Providers to providers in \Umbraco\Plugins\courier\pages\editLocalRevision.aspx and it does fix the Add button but a whole bunch of other javascript errors showed up then.

I'm seeing it with Courier 3.0.4 and Umbraco 7.4.3 too. Revisions have never quite worked for me but it is an easy way to test custom resolvers. When I've talked to Umbraco partners they've counseled me to only use the context menu deploy because it is reliable. Seems to me that revisions were completely untested in Courier 3.

Umbraco, if the Revisions feature is dead please say so.


Shola 02 Feb 2017, 21:47:37

Interesting. @twamley Can you show me the context menu for deploying datatypes? I can't find one. I only see "Courier" when right-clicking content nodes, document types, etc.


Wincent 03 Feb 2017, 11:47:32

I get the same problem with Courier 3.0.4 and Umbraco 7.5.8


Vilen 10 Feb 2017, 08:27:09

Same here with 3.0.4 / 7.5.9


Shola 24 Feb 2017, 19:50:48

@pploug Is this being looked at yet? Can you vouch for any of the above fixes in the meantime?

Is there anything at all we do to start using Courier to deploy datatypes again? We've been a bit stuck here this past month and hesitant to keep using it. Anything at all is much appreciated.


Shola 10 Mar 2017, 18:28:39

@jim@umbraco.com Any word on progress on this? I guess I'm a bit desperate at this point. Since we can't push new datatypes, we can't push doctypes that use them, and thus we can't push content. Does anyone at least know of another way to push new/edited datatypes?


Jim Jensen 13 Mar 2017, 08:18:15

@oooshola I sure understand your frustrations. I will do my best to push for a solution. There will be more reporting of this very issue soon, and I am sure this will also add to the priority of this.


Shannon Deminick 14 Mar 2017, 00:23:16

Hi All,

You can find a new nightly build with this fixed, along with a few other UI quirks fixes:

Umbraco package: https://umbraconightlies.blob.core.windows.net/umbraco-deploy/Courier.v3.0.8-nightly458.zip

Hotfix (meaning you can just replace the files manually): https://umbraconightlies.blob.core.windows.net/umbraco-deploy/Courier.v3.0.8-nightly458.HotFix.zip

We'll get the official 3.0.8 out next week.


Shola 14 Mar 2017, 17:20:16

@jim@umbraco.com @Shandem Thank you so much! I will try it out this week.


Vilen 13 Apr 2017, 10:17:33

@Shandem any chance to have public 3.0.8?


Shannon Deminick 18 Apr 2017, 02:58:37

Yup i'll get that done as soon as i can and let you know... sorry about that!


Shannon Deminick 27 Apr 2017, 22:14:57

Sorry for the delay! 3.0.8 is up on OUR now: https://our.umbraco.org/projects/umbraco-pro/umbraco-courier/


Priority: Show-stopper

Type: Bug

State: Fixed

Assignee:

Difficulty:

Category:

Backwards Compatible: True

Fix Submitted:

Affected versions: 3.0.3, 3.0.4, 3.0.5, 3.0.6

Due in version: 3.0.8

Sprint: Sprint 55

Story Points:

Cycle: