COU-524 - Remove warnings that a session can be closed when no session is opened

Created by Shannon Deminick 08 Mar 2017, 10:19:28 Updated by Rune Strand 20 Mar 2017, 22:23:42

Relates to: COU-540

Subtask of: COU-521

we see this many times in the logs:

WARN Umbraco.Courier.Persistence.V6.NHibernate.NHibernateProvider - [Thread 445] Closing session called but there is no session open: 03bdce85-7edd-4730-a115-601f7bb6ef23

Though in some cases it may not be causing problems, it actually might be in other cases, we should fix it.

Comments

Shannon Deminick 15 Mar 2017, 23:40:08

The reason this is logged is because the session get's explicitly closed with Provider.CloseSession and then it gets closed again because the Repository.Dispose also ensures the session is closed. So to 'fix' this i'm just removing the warnings since it's fine to explicitly close it and in dispose it will already detect if it's already closed.


Shannon Deminick 15 Mar 2017, 23:41:21

Done in https://github.com/umbraco/UmbracoDeploy/commit/7333cec61ce9772a46b9626818c1a9183e01918f


Priority: Normal

Type: Task

State: Fixed

Assignee:

Difficulty:

Category:

Backwards Compatible: True

Fix Submitted:

Affected versions:

Due in version: 3.0.8

Sprint: Sprint 55

Story Points:

Cycle: