COU-526 - Better error handling, fixes UI progress indicator, better error messaging

Created by Shannon Deminick 08 Mar 2017, 10:29:38 Updated by Claus Jensen 10 Mar 2017, 10:26:42

Tags: Unscheduled

Subtask of: COU-521

  • Turns out the whole way the UI tracked statuses was broken a few versions ago because a Unique Id was not set on the ExtractionTask, then we wrapped it in a Sequential task, then we didn't update the JS to look for that type, so basically the UI has been broken for a while and never really tells you if it completed - To Test, do an extraction and you should see the big green completed text
  • Turns out the messaging that was bubbled to the UI was confusing (when it used to work) and it would say things like Processing Revision: Revision or Processing Revision: _234234232342423423 which is not nice at all, for cloud it should say nice things so now it does, it will say: "Processing Courier data" or "Packaging Courier data", for normal Courier the old logic applies but that makes sense because revisions are actually named correctly
  • The error messaging has been updated, for known errors, we'll display a much nicer error message
  • We now will check if a deployment is in progress already before continuing
  • We now detect if a session is already open and an exception occurs because of that and will show a nice message
  • Some additional Null/safety checks for AddToQueue - NullReferenceException

We see this quite often in logs:

2017-03-08 08:20:55,046 [504] ERROR Umbraco.Courier.Core.TaskManager - [Thread 504] Error PackagingTask with id: 7319827b-cf3d-48ad-b989-abdfd450c2da
System.NullReferenceException: Object reference not set to an instance of an object.
   at Umbraco.Courier.Core.Packaging.RevisionPackaging.AddToQueue(RevisionManifest manifest)
   at Umbraco.Courier.Core.Tasks.PackagingTask.Run()
   at Umbraco.Courier.Core.BackgroundTaskRunner`1.ConsumeTaskInternal(T task)

Comments

Shannon Deminick 09 Mar 2017, 16:26:40

PR is here : https://github.com/umbraco/UmbracoDeploy/pull/85

This PR is also for: http://issues.umbraco.org/issue/COU-522


Claus Jensen 10 Mar 2017, 10:26:29

Have reviewed and tested this - error messages are a lot nicer now and actually shows :) Also seems like the changes for tracking the right tasks in cases with sequential tasks are now working as they should - we've fixed this before so not really sure how this was broken again.


Priority: Normal

Type: Task

State: Fixed

Assignee:

Difficulty:

Category:

Backwards Compatible: True

Fix Submitted:

Affected versions:

Due in version: 3.0.7

Sprint: Sprint 54

Story Points:

Cycle: