COU-573 - Given a courier file with a null for startNodeId, Courier creates a deploy-failed

Created by Sebastiaan Janssen 22 May 2017, 10:43:45 Updated by Shannon Deminick 24 May 2017, 06:13:31

Subtask of: COU-521

In a site with some pretty old courier files (9 months old) some of the datatypes do not have a <Value /> node in the startNodeId prevalue.

This causes an exception in Umbraco.Courier.DataResolvers.PropertyDataResolvers.ReplaceStartNodeId because we assume that node is always available. We can easily check for this and not do anything instead.

Comments

Sebastiaan Janssen 22 May 2017, 10:49:08

PR: https://github.com/umbraco/UmbracoDeploy/pull/95


Shannon Deminick 24 May 2017, 06:13:19

definitely a required code change, null checks FTW :)


Priority: Normal

Type: Bug

State: Fixed

Assignee:

Difficulty:

Category:

Backwards Compatible: True

Fix Submitted:

Affected versions: 3.1.1

Due in version: 3.1.2

Sprint:

Story Points:

Cycle: 1