COU-578 - Fixing "optimizations" in LocalLinks resolver

Created by Claus Jensen 26 May 2017, 11:48:48 Updated by Claus Jensen 27 May 2017, 07:15:49

Subtask of: COU-521

This optimization won't work as it will result in returning the entire ShouldExecute based on the result of just checking the first property.

We need to run through all properties on an item and only return when one is true (skip the rest) or when all has been checked and there were no matches.

https://github.com/umbraco/UmbracoDeploy/blob/dev-v7/Contrib/Providers/Umbraco.Courier.DataResolvers/ItemDataResolvers/LocalLinks.cs#L55

Comments

Claus Jensen 26 May 2017, 11:51:39

PR: https://github.com/umbraco/UmbracoDeploy/pull/97


Mikkel Holck Madsen 26 May 2017, 11:58:53

Important :-)


Priority: Normal

Type: Bug

State: Fixed

Assignee:

Difficulty:

Category:

Backwards Compatible: True

Fix Submitted:

Affected versions: 3.1.1

Due in version: 3.1.2

Sprint:

Story Points:

Cycle: 1