COU-579 - LocalLinks are not set correctly when extracted

Created by Claus Jensen 27 May 2017, 06:35:05 Updated by Mikkel Holck Madsen 29 May 2017, 11:29:37

Subtask of: COU-521

LocalLinks are currently saved with a href="/{localLink} format when saved by Core, but the regex pattern used to locate these matches the forward-slash as an optional (we most likely haven't been saving these with slashes always so thats why the pattern needs to match optional).

When Courier uses the same regex pattern to replace the localLink values, it also needs to make sure that the replacing value contains the forward-slash. If there's no prepended slash, TinyMCE will add stuff (/umbraco/) to the href value in some cases. I have no clue how it determines when and when not to do this ... seems to only happen on some sites in some situations!

If this value is then saved to the database, the localLink functionality breaks as it now looks like href="/umbraco/{localLink}".

Comments

Claus Jensen 27 May 2017, 06:36:26

PR: https://github.com/umbraco/UmbracoDeploy/pull/98


Mikkel Holck Madsen 29 May 2017, 07:03:59

hmm the tests are failing with these changes. I think they presume the link isn't prefixed with the /


Mikkel Holck Madsen 29 May 2017, 07:20:54

I updated the unittests in this commit: https://github.com/umbraco/UmbracoDeploy/commit/39dd2daac67bbb4299def770ed990d02903b0a1f


Priority: Normal

Type: Bug

State: Fixed

Assignee:

Difficulty:

Category:

Backwards Compatible: True

Fix Submitted:

Affected versions: 3.1.1

Due in version: 3.1.2

Sprint:

Story Points:

Cycle: 2