COU-588 - Relations are not handled

Created by Claus Jensen 28 Jun 2017, 12:08:28 Updated by Warren Buckley 11 Jul 2017, 08:46:09

Tags: Unscheduled

Subtask of: COU-521

Relations are not handled when transferred, due to [XmlIgnore] on the PostProcessing attribute causing the postprocessing to always be set as false when extracting, regardless of what it was set to when packaging.

https://github.com/umbraco/UmbracoDeploy/blob/dev-v7/Core/Umbraco.Courier.Core/Item.cs#L71

Comments

Claus Jensen 28 Jun 2017, 12:43:41

PR: https://github.com/umbraco/UmbracoDeploy/pull/101


Claus Jensen 28 Jun 2017, 12:45:10

Flag document for postprocessing if there's any relations. If a relation can't be persisted due to a missing reference, don't throw - just skip the relation for now.


Warren Buckley 11 Jul 2017, 08:38:12

The code changes all make sense @claus Is there a way I should test this to verify it works as described?


Claus Jensen 11 Jul 2017, 08:42:22

I think you can do something like this to test (believe that's how I tested it when fixing the issue):

Site1:

  • create doc1
  • create a copy of doc1 named doc2 and check the relations thingy so it creates a relation to the original one
  • ensure the relation exists in the db

Site2:

  • deploy doc1 from site1 to site2
  • you should have no relations in db of site2
  • deploy doc2 from site1 to site2
  • you should have a relation existing in the db now on site2


Warren Buckley 11 Jul 2017, 08:46:06

Merged & marking as fixed


Priority: Normal

Type: Bug

State: Fixed

Assignee:

Difficulty:

Category:

Backwards Compatible: True

Fix Submitted:

Affected versions: 3.1.3

Due in version: 3.1.4

Sprint: Sprint 63

Story Points: 1

Cycle: 3