COU-600 - The CourierWebserviceRepositoryProvider allocates a ton of RepositoryWebservice objects

Created by Shannon Deminick 26 Jul 2017, 05:40:46 Updated by Claus Jensen 09 Aug 2017, 07:03:49

Subtask of: COU-521

anytime the CourierWebserviceRepositoryProvider executes, it does this:

     var loginName = "";
     var pass = "";
     GetloginAndPass(UserId, out loginName, out pass);
     using (var repo = Webservice(loginName, pass))
     {
            //do stuff
     }

Everytime this executes it's additional overhead since it's allocating and disposing a new instance of RepositoryWebservice, further it keeps looking up the login/password when this only needs to happen once.

These allocations don't need to happen and fixing will reduce the memory footprint. Also the RepositoryWebservice can be disposed when the instance of the CourierWebserviceRepositoryProvider is disposed instead of every method.

Comments

Shannon Deminick 26 Jul 2017, 05:41:22

Done in commit: https://github.com/umbraco/UmbracoDeploy/commit/35efdd8d968597eda52cd5b623f621042a42ec36


Priority: Normal

Type: Bug

State: Fixed

Assignee:

Difficulty:

Category:

Backwards Compatible: True

Fix Submitted:

Affected versions: 3.1.3

Due in version: 3.1.4

Sprint: Sprint 65

Story Points: 1

Cycle: 3