COU-605 - Update Courier UI to not use the legacy images/css that have been removed in 7.7

Created by Shannon Deminick 31 Jul 2017, 07:27:15 Updated by Claus Jensen 25 Aug 2017, 06:36:38

Subtask of: UAASSCRUM-966

Courier's UI still references some old UI bits but we've removed most of this legacy stuff in 7.7 so it will need to be updated.

5 Attachments

Comments

Shannon Deminick 31 Jul 2017, 07:45:24

This should simply be updating any existing CSS references that are legacy to use current ones and same goes for images.


Shannon Deminick 31 Jul 2017, 10:22:18

An example (see screenshot) we'll need to search for all of these image references. Then we need to look at the courier section to see what's missing there. I've already fixed up the error reporting screen a little too.


Shannon Deminick 14 Aug 2017, 10:13:39

https://github.com/umbraco/UmbracoDeploy/pull/107

see screenshots for before/after

To test:

  • build and install this version of courier (however you normally test courier)
  • have the chrome dev tools open
  • go to the courier editors in the courier section and in the users section and ensure that anything you do doesn't cause a 404 for some image that is no longer existing


Shannon Deminick 15 Aug 2017, 10:21:02

This PR fixes these too: http://issues.umbraco.org/issue/COU-609 http://issues.umbraco.org/issue/COU-591


Claus Jensen 15 Aug 2017, 12:14:02

I get this after installing the Courier package in a clean 7.7 site:

Method not found: 'Void umbraco.BusinessLogic.User.addApplication(System.String)'.

Description: An unhandled exception occurred during the execution of the current web request. Please review the stack trace for more information about the error and where it originated in the code. 

Exception Details: System.MissingMethodException: Method not found: 'Void umbraco.BusinessLogic.User.addApplication(System.String)'.

Source Error: 

An unhandled exception was generated during the execution of the current web request. Information regarding the origin and location of the exception can be identified using the exception stack trace below.

Stack Trace: 


[MissingMethodException: Method not found: 'Void umbraco.BusinessLogic.User.addApplication(System.String)'.]
   Umbraco.Courier.UI.Application.InstallHelper.GiveCurrentUserAccess() +0
   Umbraco.Courier.UI.Usercontrols.Installer.Page_Load(Object sender, EventArgs e) +321
   System.Web.Util.CalliEventHandlerDelegateProxy.Callback(Object sender, EventArgs e) +51
   System.Web.UI.Control.OnLoad(EventArgs e) +95
   System.Web.UI.Control.LoadRecursive() +59
   System.Web.UI.Control.LoadRecursive() +131
   System.Web.UI.Control.LoadRecursive() +131
   System.Web.UI.Control.LoadRecursive() +131
   System.Web.UI.Control.LoadRecursive() +131
   System.Web.UI.Control.LoadRecursive() +131
   System.Web.UI.Control.LoadRecursive() +131
   System.Web.UI.Page.ProcessRequestMain(Boolean includeStagesBeforeAsyncPoint, Boolean includeStagesAfterAsyncPoint) +678

and my sites are in a completely broken state not even allowing me to see the backoffice.


Claus Jensen 16 Aug 2017, 12:12:29

The backoffice issue has been fixed here: http://issues.umbraco.org/issue/U4-10299 - Courier uses legacy trees.

Still have the addApplication error though after install. However it's possible to use it anyway - so I'll go on with testing :)


Claus Jensen 16 Aug 2017, 13:37:41

Confirmed that all assets seems to be okay. Have worked around the install issues and cleaned out the umbraco folders to ensure nothing was left over from an older installation - did not see anything 404/missing.

Have not merged this yet, as there's a few other issues in the same PR.


Claus Jensen 16 Aug 2017, 13:42:44

Added issue for the addApplication error above: http://issues.umbraco.org/issue/COU-610


Shannon Deminick 24 Aug 2017, 23:56:55

@claus should this be merged now?


Shannon Deminick 25 Aug 2017, 01:04:35

@claus Oh ... hrm ok i can see this is already merged in. That will mean that all of these changes for 3.2.0 have actually been deployed under 3.1.4 right?


Claus Jensen 25 Aug 2017, 06:15:57

Hmmm yep that is true. It would have been nice to keep the "cleanup" parts of these issues to version 3.2.0, but since the revision fixes was also part of the PR, we couldn't really wait with merging this PR in. This should be marked as 3.1.4 instead though.


Priority: Normal

Type: Task

State: Fixed

Assignee:

Difficulty:

Category:

Backwards Compatible: True

Fix Submitted:

Affected versions:

Due in version: 3.1.4

Sprint: Sprint 66

Story Points: 1

Cycle: