COU-621 - Being able to transfer Folders with Courier

Created by Robert Copilau 05 Sep 2017, 10:14:40 Updated by Shannon Deminick 11 Sep 2017, 08:48:10

Tags: Unscheduled

Subtask of: COU-521

As it is now, Courier cannot transfer folders from one environment to another.

Trying to organize docTypes in folders and transferring them to another environment is a pain - as you have to manually re-create the folder and manually move the docTypes. We also have a [new feature |http://issues.umbraco.org/issue/U4-7580]that gives the ability to rename folders which in the current state Courier can't make use of it.

NOTE: When this is going to be implemented, we need to check that [U4-7580 |http://issues.umbraco.org/issue/U4-7580]works with courier.

Comments

Claus Jensen 06 Sep 2017, 13:28:50

PR: https://github.com/umbraco/Umbraco-Courier/pull/112

We were assigning the wrong ItemProviderId to the dependency being added by the ContentTypeItemProvider.

It was assigning its own ID and was supposed to be assigning the ID of either DocumentTypeContainerItemProvider or MediaTypeContainerItemProvider.

This has worked by accident on Cloud, since we deploy these by git - this dependency link was never actually used in those cases. Folders will now be picked up as a dependency and transferred, when deploying a document type that is inside a folder.


Robert Copilau 08 Sep 2017, 08:44:27

Document types now transfer with the folder that they are enclosed in, however folder rename feature will not work with this and that is fine for now.

The problem is that when your work on you environment and do some changes to the Folder and/or the docTypes inside, Courier will not detect that the folder has been renamed, therefore folder changes will not persist.

This "issue" will not brake anything, which is why we should leave it like that until someone really needs it.


Shannon Deminick 11 Sep 2017, 05:24:14

Why can't we rename folders and have it work with Courier? We can rename everything else and since it's transfered by a GUID i don't see what the issue is - perhaps it's just not knowing the Courier codebase or maybe I'm misunderstanding something...


Claus Jensen 11 Sep 2017, 08:44:49

@Shandem Didn't have time to see what exactly was going on there .. turns out it's solved by simply forcing the hashcheck on the dependency: https://github.com/umbraco/Umbraco-Courier/commit/04191b537bc9c782d096f2bb71b823d1114d4b0e

Folders can't be deployed "individually" as items... they only get deployed by deploying something that lives in a folder. So just having a "does it exist" check on the dependency doesn't really detect when a folder has changed properties. Hashchecking will make sure we know if that happens.


Shannon Deminick 11 Sep 2017, 08:48:10

ahh righto!


Priority: Normal

Type: Task

State: Fixed

Assignee:

Difficulty:

Category:

Backwards Compatible: True

Fix Submitted:

Affected versions: 3.1.4

Due in version: 3.1.5

Sprint: Sprint 67

Story Points: 1

Cycle: 4