COU-626 - 3.1.4 Won't sync Umbraco.DropDown datatype within a grid editor

Created by Eric Frost 21 Sep 2017, 08:38:34 Updated by Paul Sterling 27 Sep 2017, 15:03:10

Tags: Gold partner

Relates to: COU-597

Subtask of: COU-521

After adding a native Umbraco.DropDown datatype to the document type itself and to a grid editor, it appears that with the introduction of Courier 3.1.4, this line was updated to include a blind replace of the spiderweb character with a null string:

https://puu.sh/xEFZ4/1177d142c9.png

From 3.1.3 - GridValueModel grid = JsonConvert.DeserializeObject(propertyData.Value.ToString());

To 3.1.4 - GridValueModel grid = JsonConvert.DeserializeObject(propertyData.Value.ToString().Replace("¤", "null"));

Replacing the spiderweb character with "null", ends up breaking prevalue editors that are in grid editors because the courier revision for this items shows:

"value":"nullL2 Main"

whereas when the dropdown that was added to the doctype itself shows:

¤L2 Main

The issue is also other prevalue editors. Such as radiobutton lists -- when these items get packaged up and sent over to the other site that courier is tied to, the value is never synced for the LeBlender / Grid Editor dropdown property because "nullL2 Main" isn't a value on that end

Comments

Claus Jensen 27 Sep 2017, 13:52:24

This bug happens due to the fix made in COU-597.

I've fixed it up here: https://github.com/umbraco/Umbraco-Courier/pull/114


Claus Jensen 27 Sep 2017, 13:54:33

'''Test:'''

  • Confirm dropdowns transfer correctly
  • If you want you can test the specific site where the fix causing this bug was originally reported .. I've done it though and it restores without errors.


Paul Sterling 27 Sep 2017, 15:03:10

@claus would it be possible to get a nightly build of this? Or is there already one? We have a couple of affected clients.


Priority: Normal

Type: Bug

State: Fixed

Assignee:

Difficulty:

Category:

Backwards Compatible: True

Fix Submitted:

Affected versions: 3.1.4

Due in version: 3.1.5

Sprint: Sprint 68

Story Points: 3

Cycle: 4