U4-10013 - Umbraco.MediaPicker value converter does not understand ints

Created by Jeavon Leopold 13 Jun 2017, 11:26:25 Updated by Sebastiaan Janssen 18 Jul 2017, 13:23:13

Tags: PR

The value converter for the double legacy property editor Umbraco.MediaPicker is broken as it doesn't support ints, this is because it is using the same converter as Umbraco.MediaPicker2.

This can be fixed my switching from the MediaPickerPropertyConverter to the MultipleMediaPickerPropertyConverter converter which supports both int and udi

MultipleMediaPickerPropertyConverter could also be renamed LegacyMediaPickerPropertyConverter to make it clear it's handling both legacy types?

PR to follow

Comments

Jeavon Leopold 13 Jun 2017, 11:33:02

PR: https://github.com/umbraco/Umbraco-CMS/pull/1998


Jeavon Leopold 13 Jun 2017, 11:34:50

p.s. I only came across this on a upgrade that contained Articulate as that uses the double legacy Umbraco.Media picker by default :)

If anyone else hits this, simply change the data type from Umbraco.MediaPicker to Umbraco.MultipleMediaPicker to fix it until this PR is released.


Sebastiaan Janssen 17 Jul 2017, 18:40:42

Seems to work beautifully, thanks Jeavon!


Priority: Major

Type: Bug

State: Fixed

Assignee:

Difficulty: Normal

Category:

Backwards Compatible: True

Fix Submitted: Pull request

Affected versions: 7.6.2, 7.6.3

Due in version: 7.6.5

Sprint: Sprint 63

Story Points:

Cycle: 3