U4-10098 - Update FileService to support legacy MacroScript and UserControl folders

Created by Claus Jensen 04 Jul 2017, 12:23:59 Updated by Claus Jensen 06 Jul 2017, 08:40:15

Tags: Unscheduled

Relates to: U4-10124

Subtask of: U4-9609

Although these are old and obsolete, upgraded sites could still be using these for macros. Deploy uses the FileService to access all files and should not use the filesystem directly. To be able to fetch files from these folders from Deploy, Core needs to know how to handle this.

This is required for: http://issues.umbraco.org/issue/deploy-327

Comments

Claus Jensen 04 Jul 2017, 12:30:46

PR: https://github.com/umbraco/Umbraco-CMS/pull/2030

Have added methods to FileService for handling these entities, but marked them as obsolete as they should be removed when we also drop support for the macroScripts and usercontrols folders.

For the MacroScripts it uses the same extensions and is very similar to normal partial views, so I've reused most of the base repositories and stuff for that. UserControls was a little different so is just handled separately.


Claus Jensen 04 Jul 2017, 12:44:34

Needs some fixes for shadow fs. Reopening.


Claus Jensen 05 Jul 2017, 13:40:27

No changes were needed for the latest fix - was fixed in Deploy.


Mikkel Holck Madsen 06 Jul 2017, 07:17:05

Merged PR


Priority: Normal

Type: Bug

State: Fixed

Assignee:

Difficulty: Normal

Category:

Backwards Compatible: True

Fix Submitted:

Affected versions: 7.6.3

Due in version: 7.6.4

Sprint: Sprint 62

Story Points: 1

Cycle: 2