U4-10124 - Update IFileService to handle MacroScripts and UserControls

Created by Claus Jensen 06 Jul 2017, 08:43:06 Updated by Claus Jensen 07 Jul 2017, 11:34:20

Tags: Unscheduled

Relates to: U4-10098

Subtask of: U4-9609

Add SetFileContent, GetFileContentStream and GetFileSize for MacroScript and UserControl in the FileService.

Comments

Claus Jensen 06 Jul 2017, 08:45:16

PR: https://github.com/umbraco/Umbraco-CMS/pull/2032


Mikkel Holck Madsen 06 Jul 2017, 10:58:25

Merged - Works


Shannon Deminick 06 Jul 2017, 23:47:43

Why is this a thing? Is this needed for deploy or something?


Claus Jensen 07 Jul 2017, 06:10:16

Yeah.. it's legacy but since people could be having these files in upgraded sites (and apparently the customer @mikkelhm was helping had that), Deploy will fail if a macro references one of these old files... it's a bit annoying.


Claus Jensen 07 Jul 2017, 06:11:52

But hey - it's better that it's actually handled by the FileService now, than just hacking in some File.Read/Write stuff like we most likely did in Courier :)


Priority: Normal

Type: Bug

State: Fixed

Assignee:

Difficulty: Normal

Category:

Backwards Compatible: True

Fix Submitted:

Affected versions: 7.6.3

Due in version: 7.6.4

Sprint: Sprint 62

Story Points: 1

Cycle: 2