U4-10144 - Umbraco.Web.Trees.FileSystemTreeController has breaking changes for inheritors

Created by Stephan 11 Jul 2017, 17:03:47 Updated by Shannon Deminick 25 Jul 2017, 05:10:03

Subtask of: U4-9609

In 7.6.0 the file system tree controller breaks compatibility

Comments

Stephan 11 Jul 2017, 17:08:07

PR https://github.com/umbraco/Umbraco-CMS/pull/2042

the public controller base reverts back to its original version, thus maintaining compatibility, while a second controller base is created for our own internal controllers.

review: controllers should work, packages such as bookshelf should not break anymore


Claus Jensen 12 Jul 2017, 12:28:17

Confirmed that the controllers based on FileSystemTreeController works. Code looks good - cleaned up a bit and merged in.


Dave Woestenborghs 21 Jul 2017, 08:05:44

@zpqrtbnk @kgiszewski I think this will break the latest version of Bookshelf again. See https://github.com/kgiszewski/UmbracoBookshelf/commit/d984b6a37ec718348a2debd81e8d59f4307b56e5


Stephan 21 Jul 2017, 11:11:01

'cos Bookshelf updated to the new (breaking) controller in the meantime, right?

Not sure what to do. Many others were breaking so we have to revert. Bad for Bookshelf.

Ideas?


Dave Woestenborghs 21 Jul 2017, 11:22:39

I think the fix for bookshelf is pretty easy...just revert the last changes :-)


Kevin Giszewski 21 Jul 2017, 12:52:58

Ha, I think I can do whatever we need to do for Bookshelf. Don't sweat it guys.


Stephan 24 Jul 2017, 12:06:02

So... issue got reopened because fixing, ie reverting to the original controller, would break code for anyone who would have adjusted their own code, including Forms, Bookshelf, and others. Better break only once.

And so, pending review of commit https://github.com/umbraco/Umbraco-CMS/commit/c5e7e1e39e329bd94a7afc8c172d3039c7729e1f we're back to the original breaking state.

Sorry about the confusion.


Kevin Giszewski 24 Jul 2017, 13:02:50

We love you @zpqrtbnk :)


Shannon Deminick 25 Jul 2017, 04:44:58

I've updated this task to show that 7.6.0 had a breaking change just so it's clear in the release notes.


Priority: Normal

Type: Task

State: Fixed

Assignee:

Difficulty: Normal

Category:

Backwards Compatible: False

Fix Submitted:

Affected versions:

Due in version: 7.6.0

Sprint: Sprint 64

Story Points: 1

Cycle: