U4-10171 - Treepicker used in grid Settings, unable to remove setting once applied.

Created by Mike Chambers 17 Jul 2017, 14:22:55 Updated by Sebastiaan Janssen 17 Jul 2017, 20:06:40

Tags: PR

What did you do?

{
    "label": "Link picker",
    "description": "Wrap a clickable link around the panel.",
    "applyTo": "cell",
    "key": "link",
    "view": "treepicker",
    "value": "",
    "prevalues": [
      "none"
    ]
  }

applied as a grid cell setting. Added a link, saved/published Wanted to remove the picker item by clicking on the red cross

What did you expect to happen? Picker is emptied.

What actually happened? Closes the settings dialogue so unable to remove the picked item setting.

I believe this is an event propagation issue, amending the following file resolves the issue

\Umbraco\Views\prevalueeditors\treepicker.html

<i class="icon icon-delete red hover-show pull-right" style="cursor:pointer;" ng-click="remove($index); $event.stopPropagation();"></i>

also added pointer for UX.

Comments

Sebastiaan Janssen 17 Jul 2017, 16:01:26

PR: https://github.com/umbraco/Umbraco-CMS/pull/2051


Sebastiaan Janssen 17 Jul 2017, 16:17:25

Nicely done! I've added a Core Contributor badge to your Our profile (https://our.umbraco.org/member/9103) and your fix will be in the next release!


Priority: Normal

Type: Bug

State: Fixed

Assignee:

Difficulty: Normal

Category:

Backwards Compatible: True

Fix Submitted: Pull request

Affected versions: 7.6.3

Due in version: 7.6.5

Sprint: Sprint 63

Story Points:

Cycle: 3