U4-10196 - Forms installer is not compatible with the changes made in the user-group-permissions branch

Created by Claus Jensen 05 Jul 2017, 08:29:45 Updated by Stephan 01 Aug 2017, 14:05:16

Subtask of: U4-8632

AddAllowedSections on IUser no longer exists. This is used by the Forms installer:

Umbraco.Forms.Web.Installer.InstallHelper.SetUserAccess()

Needs to be updated if this change is not reverted.

Comments

Shannon Deminick 25 Jul 2017, 05:41:42

I've updated more details on API breaking changes here: http://issues.umbraco.org/issue/U4-10103

Forms requires that:

  • IUser.AddAllowedSections exists
  • IUser.UserType exists - this is referenced 13 times in the Forms codebase
  • IUserType exists

So our options are:

Release a new forms major version targeting v7.7.0 with the updated API changes OR

Attempt to add these properties, methods and classes back into the Umbraco Core - but it might not even be possible to make these things work even if we put them back in

I'll attempt option 2 and see what happens


Shannon Deminick 25 Jul 2017, 08:41:13

I've fixed this in core in rev: 17d17cfb82ccb32909fb137dcdba01aa8dcb2a0d which puts back in a few APIs that forms uses during install. I've tested and this all works now and I think the backward compat hacks are ok just needs a code review.


Stephan 01 Aug 2017, 14:04:56

looks good to me - as good as it can be - just need to remember to get rid of it all eventually - merging


Stephan 01 Aug 2017, 14:05:11

ah well, not merging, just... fixed


Priority: Task - Pri 1

Type: Bug

State: Fixed

Assignee:

Difficulty:

Category:

Backwards Compatible: False

Fix Submitted:

Affected versions:

Due in version: 7.7.0

Sprint: Sprint 64

Story Points: 1

Cycle: