U4-10260 - Umbraco.7.7 beta - NestedContent with ModelsBuilder disabled throws error

Created by Lee Kelleher 07 Aug 2017, 13:04:11 Updated by Sebastiaan Janssen 30 Aug 2017, 08:04:49

Tags: PR

Subtask of: UAASSCRUM-1073

Mostly for @zpqrtbnk :-)

With Umbraco 7.7.0-beta, if ModelsBuilder has been disabled, e.g.

... and using Nested Content, (on the frontend) will throw an error against this line...

https://github.com/umbraco/Umbraco-CMS/blob/dev-v7.7/src/Umbraco.Web/PropertyEditors/ValueConverters/NestedContentPublishedPropertyTypeExtensions.cs#L114

As PublishedContentModelFactoryResolver.HasCurrent is true... but the PublishedContentModelFactoryResolver.Current.Factory is null.

If I enable ModelsBuilder, then this is fine, but disabling it throws a null-reference exception.

I'll supply a PR to fix this.

Comments

Lee Kelleher 07 Aug 2017, 13:09:07

PR available: https://github.com/umbraco/Umbraco-CMS/pull/2107


Sebastiaan Janssen 30 Aug 2017, 06:58:04

@leekelleher Do you have a very simple example template where this blows up? I can't get it to go through the PVC (EnablePropertyValueConverters is set to true).


Sebastiaan Janssen 30 Aug 2017, 08:03:23

Never mind I was using the plugin, not the built-in NC! :) All good!


Sebastiaan Janssen 30 Aug 2017, 08:04:49

Yep, works like a charm, thanks Lee!


Priority: Normal

Type: Bug

State: Fixed

Assignee:

Difficulty: Normal

Category:

Backwards Compatible: True

Fix Submitted: Pull request

Affected versions: 7.7.0

Due in version: 7.7.0

Sprint: Sprint 66

Story Points: 1

Cycle: