U4-10392 - Culture and hostnames with special characters can register as collisions

Created by Claus Jensen 08 Sep 2017, 09:24:30 Updated by Shannon Deminick 13 Sep 2017, 00:58:59

Tags: Regression

Is duplicated by: U4-10394

Relates to: U4-10370

Subtask of: U4-9609

Due to the change made for hostnames with special characters - in certain conditions, Urls with special characters can register as collision urls and therefore won't work.

Comments

Claus Jensen 08 Sep 2017, 09:30:20

Fixed here: https://github.com/umbraco/Umbraco-CMS/commit/921e8a252930d4326cb4ac8443d14cf517adc52e

This has to be done "the other way around" for this to not break the URL generation. Instead of encoding the path we're comparing from, we have to decode the path we're using for comparison.

Have merged, tested with various kind of url's that seem to work now again.


Shannon Deminick 12 Sep 2017, 01:45:33

We need unit tests for these sort of changes to ensure we don't have regression issues again.


Claus Jensen 12 Sep 2017, 13:06:58

Added unit tests for various cases of urls and urls with special characters, urls with hostnames and urls with hostnames with special characters.

Also added unit test for the issue with creating a child (caused by the IsPublishable change) while I was at it anyway... (and cleaned up a bunch of usings and line endings in various files where it has been annoying for a while)

https://github.com/umbraco/Umbraco-CMS/commit/0700e378302f6c038f56a566547636f4f06be968?w=1


Shannon Deminick 13 Sep 2017, 00:58:53

Great work!


Priority: Major

Type: Bug

State: Fixed

Assignee:

Difficulty:

Category:

Backwards Compatible: True

Fix Submitted:

Affected versions: 7.6.6

Due in version: 7.6.7

Sprint: Sprint 67

Story Points: 1

Cycle: 4