U4-10413 - Composition/Reorder bar gets in the way when editing or adding a property

Created by Robert Copilau 14 Sep 2017, 07:23:24 Updated by Bjarne Fyrstenborg 14 Sep 2017, 20:53:00

Tags: Unscheduled

When I try to add or rename an existing property I can't really see what I'm doing because the bar holding "Composition" and "Reorder" covers the whole name section.

See attached picture.

1 Attachments

Comments

Mads Rasmussen 14 Sep 2017, 09:10:55

PR: https://github.com/umbraco/Umbraco-CMS/pull/2195

I found out that the cssnano plugin we use has a default setting which tries to be clever and rewrites all z-indexes. The problem is when we then set a z-index through javascript all of the other z-indexes will be way lower.

I have disabled this feature and made sure that the overlay has a higher z-index than the fixed header. I have also fixed a problem in the package section where the gallery lightbox was cut-off because of z-index. I have also made sure that all of them have a lower z-index than the login screen.

The z-indexes are still a bit messy and we should look into some variables at some point. But for now, this should fix the problem.


Robert Copilau 14 Sep 2017, 09:42:20

Tested and all looks good, merged :).


Bjarne Fyrstenborg 14 Sep 2017, 11:15:30

I guess it might fix some of these PR's as well? At least the umb-overlay issue on top of login screen. https://github.com/umbraco/Umbraco-CMS/pull/2147 https://github.com/umbraco/Umbraco-CMS/pull/1633


Robert Copilau 14 Sep 2017, 13:18:14

Hey @Bjarne.Fyrstenborg, I will be looking into those PR shortly and see if they are fixed, thanks for your input :).


Robert Copilau 14 Sep 2017, 13:50:13

Hey again @Bjarne.Fyrstenborg, all the issues are now fixed! Thank you for your effort :D.


Bjarne Fyrstenborg 14 Sep 2017, 20:53:00

Thanks for reviewing the PR's @robertcopilau and closing a few more PR's :)


Priority: Normal

Type: Usability Problem

State: Fixed

Assignee:

Difficulty: Normal

Category: UI

Backwards Compatible: True

Fix Submitted:

Affected versions: 7.6.7

Due in version: 7.6.7

Sprint: Sprint 67

Story Points: 0.5

Cycle: 4