U4-10464 - Unable to select multiple items in listview when item IDs are int.MaxValue

Created by Callum Whyte 24 Sep 2017, 18:07:22 Updated by Shannon Deminick 29 Sep 2017, 03:13:52

Tags: Unscheduled PR

We have a site running the Umbraco v7.7.1 with a custom ASP.NET membership provider (rather than an Umbraco Membership Provider).

The membership provider uses Guids for member IDs meaning the ID Umbraco uses for each of our members is just int.MaxValue (2147483647). This has caused some issues with the backoffice in the past which have been fixed - U4-9042 where a change was made to rely on the member Key (our Guid) in cases where the member Id was the default value 2147483647.

Further to this I submitted a fix for deleting items in listview here: U4-9934. However, I failed to notice a further issue with selecting multiple items in listview when the items are relying on keys instead of IDs (due to the IDs being int.MaxValue / 2147483647).

As the select logic wasn't adapted to fallback to keys when IDs are int.MaxValue it is currently only possible to select 1 item in the listview - attempting to select multiple items simply results in nothing happening. The fallback to keys needs to be implemented anywhere that an ID is being used within the listviewhelper.service.js in the backoffice.

Comments

Callum Whyte 24 Sep 2017, 18:19:12

I have submitted a pull request for this change here: https://github.com/umbraco/Umbraco-CMS/pull/2212


Priority: Normal

Type: Bug

State: Fixed

Assignee:

Difficulty: Normal

Category:

Backwards Compatible: True

Fix Submitted: Pull request

Affected versions: 7.7.0, 7.6.5, 7.6.6, 7.7.1, 7.6.7, 7.6.8

Due in version: 7.6.9

Sprint: Sprint 68

Story Points:

Cycle: