U4-10510 - umb Media Grid Directive sets minHeight when minHeight is not provided

Created by Marc Goodson 07 Oct 2017, 13:56:34 Updated by Sebastiaan Janssen 08 Nov 2017, 08:35:29

Tags: Unscheduled PR

Subtask of: U4-9609

If you look in the file:

Umbraco-CMS/src/Umbraco.Web.UI.Client/src/common/directives/components/umbmediagrid.directive.js

You'll see within the activate() method the following: if (scope.itemMaxWidth)

            if (scope.itemMaxHeight) {
                itemMaxHeight = scope.itemMaxHeight;
            }

            if (scope.itemMinWidth) {
                itemMinWidth = scope.itemMinWidth;
            }

            if (scope.itemMinWidth) {
                itemMinHeight = scope.itemMinHeight;
            }

Take a closer look at the last if

The minHeight is being set, BUT we're not checking if the minHeight exists on the scope, eg should be: if (scope.itemMinHeight)

Comments

Marc Goodson 07 Oct 2017, 14:11:24

Pull request is here:

https://github.com/umbraco/Umbraco-CMS/pull/2232


Priority: Normal

Type: Bug

State: Fixed

Assignee:

Difficulty: Very Easy

Category:

Backwards Compatible: True

Fix Submitted: Pull request

Affected versions: 7.7.2

Due in version: 7.7.5, 7.6.12

Sprint: Sprint 71

Story Points:

Cycle: