U4-10609 - Password reset "view" in login screen is always hidden

Created by Bjarne Fyrstenborg 30 Oct 2017, 17:03:08 Updated by Sebastiaan Janssen 31 Oct 2017, 22:11:42

Tags: Unscheduled PR

Is duplicated by: U4-10606

We have noticed that the password reset "view" in login screen is hidden, when clicking "Forgotten password?" link in login screen. I can confirm it happens on multiple sites which has been upgraded to v7.7.4 on Umbraco Cloud.

For our own company site, the local site is still running v7.7.2 (I haven't pulled latest changes), where the toggle between login form and password reset form is working.

In Umbraco 7.7.4 all these partial view in now wrapped inside ng-show="view == 'login'", which break the other partial view options like:

  • request-password-reset
  • set-password
  • password-reset-code-expired

3 Attachments

Comments

Bjarne Fyrstenborg 30 Oct 2017, 17:14:55

There hasn't been many changes in the login view recently: https://github.com/umbraco/Umbraco-CMS/commits/edfe2122276f58f0c1bf16e27eb2c12b84b7b7e7/src/Umbraco.Web.UI.Client/src/views/common/dialogs/login.html

I am wondering if this is closing the <div> at a wrong position? https://github.com/umbraco/Umbraco-CMS/blob/edfe2122276f58f0c1bf16e27eb2c12b84b7b7e7/src/Umbraco.Web.UI.Client/src/common/directives/components/umbpasswordtoggle.directive.js#L16

Maybe following makes a difference:

elem.wrap("<div class=\"password-toggle\"></div>").after(lnk);


Bjarne Fyrstenborg 30 Oct 2017, 17:44:27

The issue was caused by a missing end closing <div>tag. https://github.com/umbraco/Umbraco-CMS/pull/2272


Priority: Major

Type: Bug

State: Fixed

Assignee:

Difficulty:

Category:

Backwards Compatible: False

Fix Submitted: Pull request

Affected versions: 7.7.4

Due in version: 7.7.5

Sprint: Sprint 71

Story Points:

Cycle: 5