We have moved to GitHub Issues
Created by Shannon Deminick 02 Nov 2017, 03:30:27 Updated by Warren Buckley 06 Nov 2017, 08:30:52Tags: Unscheduled
Relates to: U4-9562
Subtask of: U4-9609
The HealthCheckController ctor overload specifying a IHealthCheckResolver doesn't initialize all required variables
Testing - only requires a code review
@Shandem I have merged it in as code seems fine.
However got a general dev question - why do we need this new signature & make the current one obsolete where it was loading the HealthCheck config in via
UmbracoConfig & the new signature is using it from the parameter?
@Wawarren.buckley because it should have been like that before - we should be injecting all dependencies into objects via constructors and not relying on any singletons, this makes things testable - it's the principles of dependency injection.
Thanks for the explanation @Shandem
Backwards Compatible: True
Due in version: 7.7.5
Sprint: Sprint 71
Story Points: 0.5