U4-10639 - Image picker add link is no longer square

Created by Bjarne Fyrstenborg 06 Nov 2017, 12:50:49 Updated by Mads Rasmussen 19 Dec 2017, 09:47:20

Tags: PR Gold partner

Relates to: U4-10386

Subtask of: U4-9609

The media picker now has a "add-link-square" class for images in media picker property editor. https://github.com/umbraco/Umbraco-CMS/blob/04f64cd80416fed1d4c7ff652e85bc4c903c7c0e/src/Umbraco.Web.UI.Client/src/views/propertyeditors/mediapicker/mediapicker.html#L35

Added in this commit https://github.com/umbraco/Umbraco-CMS/commit/dc937ec9425840e516ae0d4ee194e8f3916406c9#diff-5dfb1d66507966c2d20bbc69455d7045

However if affect the style of image picker prevalue editor, which no longer has a square link. https://github.com/umbraco/Umbraco-CMS/blob/5397f2c53acbdeb0805e1fe39fda938f571d295a/src/Umbraco.Web.UI.Client/src/views/prevalueeditors/imagepicker.html

To reproduce add background image to grid styles as mentioned here: https://our.umbraco.org/documentation/getting-started/backoffice/property-editors/built-in-property-editors/grid-layout/settings-and-styles#sample-settings

Furthermore is also show the thumbnail list even no image(s) has been picked.

3 Attachments

Comments

Bjarne Fyrstenborg 06 Nov 2017, 18:24:13

PR: https://github.com/umbraco/Umbraco-CMS/pull/2308


Bjarne Fyrstenborg 13 Nov 2017, 11:11:41

@Shandem @nul800sebastiaan can you add "PR" tag to this one? :)


Priority: Normal

Type: Bug

State: Fixed

Assignee:

Difficulty: Normal

Category:

Backwards Compatible: True

Fix Submitted: Pull request

Affected versions: 7.7.4, 7.6.11, 7.7.5, 7.6.12, 7.7.6

Due in version: 7.7.8

Sprint: Sprint 74

Story Points: 0.5

Cycle: 6