U4-10685 - Backoffice content chooser not positioned correctly after upgrade from 7.4.3 to 7.7.5

Created by Charlie Anstey 14 Nov 2017, 17:51:41 Updated by Sebastiaan Janssen 04 Jan 2018, 13:52:20

Is duplicated by: CON-1199

Is duplicated by: U4-10689

Is duplicated by: U4-10763

=What did I do?=

  • Backed up database of existing local 7.4.3 installation
  • Updated installation to 7.7.5 via NuGet
  • Merged Web.config changes and resolved a breaking change in customised RoutingConfig
  • Migrated installation/DB to 7.7.5 successfully
  • Tested (successfully) frontend website and web app (custom APIs driving React.js web app) to ensure working
  • Tried adding rows of content to a new node

=What did I expect to happen?=

When scrolling down the rows of content in the backoffice, the "Choose type of content" dialog should appear centrally on the screen, as a modal dialog.

=What actually happened?=

Having added a few content rows with a variety of content, the dialog is no longer visible when clicking "Add content".

Attached animated gif demonstrates the issue.

Having quickly checked in Chome DevTools, the dialog's .umb-overlay-center class has it position absolutely, meaning (for me at least) it's positioned relative to the grid editor rather than statically within the view. When I disable position: absolute, it falls back to .umb-overlay's position: fixed which makes more sense - although it's not centered to the grid editor, it is at least is visible when scrolled further down the view. See attached images 2 and 3.

I may have missed something as part of the upgrade to do with caching the backoffice frontend code. But it's all working with the updated UI so I'm guessing not?

Edit: Updated title Edit 2: Updated description with an anecdotal check of the dialog's CSS positioning and screenshots

6 Attachments

Download grid.html

Comments

Sebastiaan Janssen 15 Nov 2017, 09:18:08

Hmmm, that's very annoying!

I think it might have been caused by this fix: https://github.com/umbraco/Umbraco-CMS/commit/422be31c4e90bca382eb01588b6291e3c72d2be5

Can you try to update to the attached grid.html in ~\Umbraco\Views\propertyeditors\grid\grid.html - then you will need to change the version in ClientDependency.config to bust the browser cache.

Let me know if that fixes it!


Charlie Anstey 15 Nov 2017, 09:34:27

Hi @sebastiaan,

Yep that fixes the issue. Reverting the change to grid.html from commit https://github.com/umbraco/Umbraco-CMS/commit/422be31c4e90bca382eb01588b6291e3c72d2be5 resolves it.

Charlie


Sebastiaan Janssen 15 Nov 2017, 09:44:13

Thanks for the quick check, we'll get it reverted for the next version, apparently this fix did more harm then good unfortunately.


Charlie Anstey 15 Nov 2017, 09:48:28

No worries, thanks for the quick initial response and a spot-on RCA.


Sofie Toft 15 Nov 2017, 12:41:13

Hi @sebastiaan I've seen this on a few project today as well, http://issues.umbraco.org/issue/U4-10689

I've tested this out on a 7.6 project, and is seems to be an issue there as well. This might not be a new issue?


Charlie Anstey 15 Nov 2017, 12:46:03

Hi @stk@umbraco.com, it looks like @sebastiaan added fixes on this for minor versions 7.7.x and 7.6.x so you'd be right. I've marked http://issues.umbraco.org/issue/U4-10689 as a duplicate - hope that's okay.


Sebastiaan Janssen 15 Nov 2017, 12:48:46

@stk@umbraco.com Ah! I didn't see that one. Yes, this will be a problem for both 7.6.12 and 7.7.5 at the moment, they both contain this changed grid.html file.


Sebastiaan Janssen 15 Nov 2017, 13:42:09

Reverted in https://github.com/umbraco/Umbraco-CMS/commit/054ac78970778ebad8717f068a10f014477d0bdc


Bjarne Fyrstenborg 15 Nov 2017, 14:14:28

I was just about to report this issue too since I now in v7.6.12 don't see the content selector / grid editor selector - only when page has none or very little scroll.


Lucas 15 Nov 2017, 15:31:16

@sebastiaan what about cloud, is there a hot fix soon? or should we just wait to the new release 7.7.6 is done? right now is a major block for creating content


Ben Palmer 16 Nov 2017, 08:16:35

Hi, I'm not familiar with Umbraco Cloud but we came up with a quick fix over at: https://our.umbraco.org/forum/using-umbraco-and-getting-started/89214-grid-editor-add-content-window-display-issue

Might help out in the short term.


Priority: Critical

Type: Bug

State: Fixed

Assignee:

Difficulty: Normal

Category: UI

Backwards Compatible: True

Fix Submitted:

Affected versions: 7.7.5, 7.6.12

Due in version: 7.7.6, 7.6.13

Sprint:

Story Points:

Cycle: