U4-10688 - Obsolete property editors showing

Created by Daniel Chenery 15 Nov 2017, 11:05:17 Updated by Robert Copilau 26 Feb 2018, 11:41:05

Tags: Unscheduled PR

Subtask of: U4-9609

Obsolete property editors are still available via the Document Type settings screen, regardless of the the showDeprecatedPropertyEditors setting.

1 Attachments

Comments

Niels Hartvig 24 Feb 2018, 11:31:47

PR: https://github.com/umbraco/Umbraco-CMS/pull/2474


Niels Hartvig 24 Feb 2018, 11:32:32

As this setting haven't worked (since forever?), it's worth considering the impact for upgrades as if any obsolete property editors is in use and the settings showDeprecatedPropertyEditors is false you'll get an exception.


Niels Hartvig 24 Feb 2018, 11:34:07

One solution could be to change the implementation and only do the check for showDeprecatedPropertyEditors in the controller where editors are fetched (for the content type editor)


Niels Hartvig 26 Feb 2018, 08:25:35

PR changed to only do the check on controller level


Robert Copilau 26 Feb 2018, 11:40:59

Obsolete property editors will not show if you either create or edit a document type - already in use obsolete property editors work just fine. Merging.


Priority: Normal

Type: Bug

State: Fixed

Assignee:

Difficulty: Normal

Category:

Backwards Compatible: True

Fix Submitted:

Affected versions:

Due in version:

Sprint: Sprint 79

Story Points:

Cycle: