We have moved to GitHub Issues
Created by Lee Kelleher 18 Jan 2018, 10:31:28 Updated by Lee Kelleher 24 Jan 2018, 11:47:14Tags: PR
Subtask of: U4-9609
If the first ID in the MNTP value is a trashed content node, then
ConvertSourceToObject method would not be able to find the content node, so it would check if the ID is a media or member node, both of these incur a database call.
This can cause a detrimental performance impact on the website.
A potential fix for this could be to use the
startNode.type prevalue to detect the node type, (e.g. Content, Media or Member).
Then the prevalue could be cached in a private
ConcurrentDictionary and refreshed using the
''(Much like the Slider, Tags and NestedContent value-converters do)''
PR submitted: https://github.com/umbraco/Umbraco-CMS/pull/2397
The code looks good and works, awesome job @leekelleher as always :). Merging.
Backwards Compatible: True
Fix Submitted: Pull request
Affected versions: 7.7.8
Due in version: 7.7.10
Sprint: Sprint 77
Story Points: 1