U4-10876 - Content Picker 2 can search outside of it's selected start node

Created by Jeavon Leopold 22 Jan 2018, 17:40:13 Updated by Sebastiaan Janssen 01 Mar 2018, 14:03:49

Subtask of: U4-9609

You create a content picker and set the data type start node to a specific parent. However if the user uses the search bar they can search and pick content items that are above or to the side of the start node which is not desirable!

I'm not sure what if any other pickers this may effect

2 Attachments

Comments

Paul Sterling 30 Jan 2018, 22:46:32

(7.7.9) Have also noticed that if the Start Node is set to List View, then the child items are rendered in the dialog even if the User or User Group does not have permission for that node.


Robert Copilau 26 Feb 2018, 10:25:59

Hey @paul, I can't seem to reproduce the issues that you mentioned above, could you provide some detailed steps on how to reach the results you had?

*With the issue nr 1, I was not able to search outside the selected content node. (see attachment) *With nr 2, I am not quite sure if I did it right. I have a user with the Translators group assigned, which has access to the Translation section and have added "People" (list view) as content start node. When I log in with that user, am I suppose to see the "People" even if I don't have access to the Content section?


Robert Copilau 28 Feb 2018, 11:19:50

I will close this as the issue can't be reproduced. Feel free to re-open if the issue persists or if we receive detailed steps on how to reproduce it.


Jeavon Leopold 28 Feb 2018, 11:25:45

@robertcopilau which part can't you reproduce?


Robert Copilau 28 Feb 2018, 11:29:37

@crumpled_jeavon "search outside of it's selected start node" and the one Poul mentioned. Just noticed that I did not mention you too Jeavon when I asked for more info, sorry about that.


Jeavon Leopold 28 Feb 2018, 11:44:39

Np @robertcopilau

The search shown in this screenshot should not be possible as the start node is set to "about us"


Jeavon Leopold 28 Feb 2018, 11:44:52

Zip coming your way shortly


Robert Copilau 28 Feb 2018, 11:47:57

Thanks :), I'll start looking into it right away.


Jeavon Leopold 28 Feb 2018, 11:48:56

https://www.dropbox.com/s/msqc9l24fstqjs0/77Test.Web.zip?dl=0 user: admin@umbraco.com password: password12345678


Robert Copilau 28 Feb 2018, 12:04:44

Ok, so it seems that the issue lies with the content type not having the list view on. If list view is enabled searching only goes for the set node, otherwise will search outside. On it.


Jeavon Leopold 28 Feb 2018, 13:01:42

@robertcopilau ah yes, if the start node is a list view then it works fine


Robert Copilau 28 Feb 2018, 15:16:30

PR:https://github.com/umbraco/Umbraco-CMS/pull/2486

Testing: *Create document type and add a content picker *Add a start node to the content picker, make sure the node is not in list view mode
*Create the create the document type and search for something inside the content picker overlay *Make sure that the search results are from the start node only


Mads Rasmussen 01 Mar 2018, 09:47:10

Tested and it works 👍


Priority: Normal

Type: Bug

State: Fixed

Assignee:

Difficulty: Normal

Category:

Backwards Compatible: True

Fix Submitted:

Affected versions: 7.7.7

Due in version: 7.9.2

Sprint: Sprint 79

Story Points: 1

Cycle: 8