U4-10950 - Check box not working in nested content

Created by Robert Copilau 08 Feb 2018, 11:16:25 Updated by Heather L Floyd 18 May 2018, 03:03:53

Tags: Unscheduled

Relates to: U4-11348

Your report will have a greater chance of being addressed if you can give us clear steps to reproduce the issue, please answer the following questions in as much detail as possible: What did you do?

What did you expect to happen?

What actually happened?

Comments

Robert Copilau 08 Feb 2018, 11:19:31

PR:https://github.com/umbraco/Umbraco-CMS/pull/2434

  • Checking to see if the value is json, if it is, we ToString() to get the value if not we leave it be. Before we would try to convert the whole json object to int and it would fail


Stephan 08 Feb 2018, 12:01:45

Have commented on the PR, can you have a look?


Robert Copilau 08 Feb 2018, 12:04:05

Will do!


Robert Copilau 08 Feb 2018, 12:17:59

Updated PR: https://github.com/umbraco/Umbraco-CMS/pull/2434/commits/151c35bc4754fc8450ee7f62a413d0a0ddf74e6e

  • Moved JValue check, in TryToConvertValueToCrlType


Stephan 08 Feb 2018, 12:43:01

merged!


Priority: Normal

Type: Task

State: Fixed

Assignee:

Difficulty: Normal

Category:

Backwards Compatible: True

Fix Submitted:

Affected versions: 7.7.10

Due in version: 7.7.11, 7.8.1

Sprint:

Story Points: 1

Cycle: 8