U4-10958 - Broken MultiNodeTreePicker for Media types

Created by Robert Copilau 09 Feb 2018, 12:59:00 Updated by Sebastiaan Janssen 21 Feb 2018, 11:17:45

Tags: Unscheduled

Is duplicated by: U4-10961

Relates to: U4-10986

Note: Workaround available in this comment: http://issues.umbraco.org/issue/U4-10958#comment=67-44546

If you're using MNTP to pick media items and have property value converters (PVC) enabled, your site will lose all links to the media items in 7.7.10 & 7.7.11.

Instead of trying to find media items, the PVC looks for members.

The opposite is true as well, if you've picked member items then the new version will try to find them in the media section.

1 Attachments

Download WorkaroundMultiNodeTreePickerPropertyConverter.cs

Comments

Robert Copilau 09 Feb 2018, 13:11:06

PR:https://github.com/umbraco/Umbraco-CMS/pull/2438


Sebastiaan Janssen 09 Feb 2018, 14:17:58

The attached file can be dropped into App_Code and is a workaround for this issue.

The workaround just takes the fixed code above and it will be used instead of the PVC built into Umbraco so this also fixes the media and member mixup without having to upgrade Umbraco. You can delete the workaround when 7.7.12 is out and you've upgraded to it.


Jacob Midtgaard-Olesen 09 Feb 2018, 14:51:23

Note: This doesn't impact 7.8, so upgrading is also an option.


Richard Rees 12 Feb 2018, 22:31:10

I've dropped the file into App_Code but it's made no difference. I'm still getting 0 record count for members I added via MNTP


Sebastiaan Janssen 19 Feb 2018, 16:18:59

Added an additional fix to get member data correctly, we were passing in a UDI identifier but TypedMember(object id) did not at all expect a UDI. This is now updated:

https://github.com/umbraco/Umbraco-CMS/commit/a551881ce2546fcf71e98700d450365b90fad14e

7.7.12 is out tomorrow with the appropriate fixes in it.

@umbraco@purplespiral.com I assume you also had problems getting picked members back? I missed your comment last week, sorry about that!


Sebastiaan Janssen 21 Feb 2018, 11:17:02

Please note, that due to an error, version 7.7.12 was built and release off the wrong commit. In 7.7.12, picking media items works just fine but members don't work yet. There's an updated workaround for the issue in the new issue here: http://issues.umbraco.org/issue/U4-10986#comment=67-44785


Priority: Normal

Type: Task

State: Fixed

Assignee:

Difficulty:

Category:

Backwards Compatible: False

Fix Submitted:

Affected versions: 7.7.10, 7.7.11

Due in version: 7.7.12

Sprint: Sprint 78

Story Points: 0.5

Cycle: 8