U4-11032 - Consolidate the number of dropdown property editors into one

Created by Niels Hartvig 01 Mar 2018, 13:22:52 Updated by Shannon Deminick 22 Mar 2018, 08:34:40

Tags: PR

Is duplicated by: U4-10276

In the list of property editors there's four (4!) variations of dropdowns. They should be consolidated into one that offers either single choice or multiple choice and then work like the other pre value editors in terms of how they publish values.

2 Attachments

Comments

Niels Hartvig 06 Mar 2018, 10:11:06

PR https://github.com/umbraco/Umbraco-CMS/pull/2502


Niels Hartvig 06 Mar 2018, 10:18:56

Screenshots attached to show the difference and consistency this PR brings


Robert Copilau 19 Mar 2018, 13:38:51

Looks good, merging!


Shannon Deminick 21 Mar 2018, 01:12:45

This shouldn't have been merged into 7.9.3 which is a patch release. This needs to go into 7.10 since this is a new feature which also deprecates existing functionality.

I'll revert and port over to 7.10

After 7.9.3, we will have a new branching policy which will prevent things like this easily leaking into patch releases.


Shannon Deminick 21 Mar 2018, 02:58:16

I've reverted this in 7.9 and included it in 7.10, i've also fixed up the boolean.html Html Id (see comment: https://github.com/umbraco/Umbraco-CMS/pull/2502/files#r175968685), but feedback is needed about this comment: https://github.com/umbraco/Umbraco-CMS/pull/2502#issuecomment-374809089 since we are actually removing functionality from the CMS with this change. If we want to continue being able to have publishing keys, then we'll most likely still need 2x drop down lists: one without publishing keys and one with publishing keys, or we can attempt to also publish keys based on a pre-value but without diving into the code I'm unsure if that is possible.


Sebastiaan Janssen 21 Mar 2018, 19:35:17

Setting to "Fixed" as the question has been answered, it's even backwards compatible as long as you enable deprecated editors.


Priority: Normal

Type: Feature (request)

State: Fixed

Assignee:

Difficulty: Normal

Category:

Backwards Compatible: True

Fix Submitted:

Affected versions:

Due in version: 7.10.0

Sprint: Sprint 81

Story Points: 1

Cycle: 9