We have moved to GitHub Issues
Created by Warren Buckley 04 Apr 2018, 08:47:46 Updated by Robert Copilau 19 Apr 2018, 06:39:44
Subtask of: U4-11114
If the default language is missing for content, and content is also missing in the selected language - the content will simply not be available in the tree.
This requires a new API Endpoint to take in a language ID and return tree nodes as the chosen language
To get 'real' data in the tree, we need to wait for this task http://issues.umbraco.org/issue/U4-11128
In the meantime, I've wired up the back end to change the tree node names to suffix the selected language.
This PR is a monster, i don't expect you to go through all of the code but please have a look at it since there might be some interesting things in there. Part of this PR is cleaning up the tree which was a huge mess: really strange jquery object and event binding is no longer there, everything is done with promises. The tree API is exposed properly on the tree directive and controllers can bind to the directive API by binding to the "api" attribute. Have fixed up tons of the promise chaining, i'm not even sure how this was working in v7! There's some old legacy code cleaned up / removed too.
So to test:
Test results: Hey @Shandem, everything works fine except for the last point whereupon browser refresh the tree should have the previously selected language which it does not. I have attached a video showing that it does not work and an image showing the error thrown upon browser refresh.
@robertcopilau I think you misinterpreted what I wrote :)
then refresh the browser and make sure that the tree is synced as expected.
All i meant was that when you refresh the browser it re-syncs the current tree node and in your video that is what it does :) refreshing and re-syncing to the currently selected language will be a different task since we'll need to track the language switch in a query string, similar to what we are doing with the navigation selector/deep link thing you did before.
I'll keep an eye out for that JS error you got, a lot has changed with the tree so will debug that when i see it.
Sorry, I expected the tree to sync with the current selected language upon refresh :). Merged.
Backwards Compatible: True
Affected versions: 8.0.0
Due in version: 8.0.0
Sprint: Sprint 83
Story Points: 3