U4-11196 - Validation UI is not working for the content name field

Created by Shannon Deminick 10 Apr 2018, 04:00:00 Updated by Robert Copilau 18 Apr 2018, 07:39:25

Subtask of: U4-11106

If you have a single or multiple languages configured and you try to save/publish a content item that doesn't have a name, validation will kick in but there is no UI indication that it is required which currently works in 7.x versions.

1 Attachments

Comments

Robert Copilau 16 Apr 2018, 06:38:55

WIP: https://github.com/umbraco/Umbraco-CMS/tree/temp-U4-11196

Fixed UI validation for the content name filed however the language picker is not taken into consideration when the field is invalid (see attached picture).


Claus Jensen 16 Apr 2018, 11:43:06

Make sure to test partial view, data types, content types, templates (they all use this thing).


Robert Copilau 16 Apr 2018, 13:43:29

PR:https://github.com/umbraco/Umbraco-CMS/pull/2589

Have tested name fields for partial view, data types, content types, media types templates and all are working.

An easy fix for the above issue (see attached image), has been to place the language picker on top of the input field, and with some css magic, everything looks the same.

Concerns: *As the language picker now stands on top of the input field, part of the long enough names will be cut by it.

How to test: *Double check if name fields for partial view, data types, content types, media types, templates are all working correctly (red borders when invalid).

NOTE: *It seems that media, content and data types do not throw validation notifications and it seems that it is broken in v7 as well. Will create a separate issue for it with more details and link it [here|http://issues.umbraco.org/issue/U4-11230].


Shannon Deminick 18 Apr 2018, 01:16:12

@robertcopilau all looks good. Can you explain a little more about the long names problem?


Shannon Deminick 18 Apr 2018, 01:17:06

I've merged this in but maybe you and @madsrasmussen can chat about the long name problem?


Robert Copilau 18 Apr 2018, 07:39:25

Yes, Mads is looking into it.


Priority: Normal

Type: Bug

State: Fixed

Assignee:

Difficulty: Normal

Category:

Backwards Compatible: True

Fix Submitted:

Affected versions: 8.0.0

Due in version: 8.0.0

Sprint: Sprint 83

Story Points: 1

Cycle: 9