We have moved to GitHub Issues
Created by Robert Dyson 10 Apr 2018, 11:26:26 Updated by Jan Skovgaard 15 Jul 2018, 12:34:03Tags: Up For Grabs PR
Although membership login is not case sensitive the registration model forces lowercase characters. The model's username/email parameter is decorated with this?
Is there any way it can be amended to include A-Z too? This would stop people complaining when they feel their email address should contain capital letters?
Many thanks.. I could make the change myself, but I'm not sure how to submit changes, or if you even want it?
Hey @dontbesorry80 ! Since you've already found the regex, make sure to update it and send a PR!
Our contribution documents should guide you on how to do this: https://github.com/umbraco/Umbraco-CMS/blob/dev-v7/CONTRIBUTING.md#how-do-i-even-begin
And if you have questions along the way maybe drop into the chat: https://gitter.im/umbraco/Umbraco-CMS
@sebastiaan Right. I'll give it a go and let you know in here when I've done it. I've always wanted to contribute ;)
@sebastiaan I tried to follow the instructions and checked in the change under a branch called UV-11198. Please let me know if there are any problems with how I've pushed it in ;)
@dontbesorry80 Hmm, I don't see it in the list here: https://github.com/umbraco/Umbraco-CMS/pulls
Maybe you haven't touched the "New pull request" button yet? ;-)
Thanks for the pointer:
Backwards Compatible: True
Fix Submitted: Pull request
Due in version: 7.12.0