U4-11198 - RegisterModel prevents uppercase characters

Created by Robert Dyson 10 Apr 2018, 11:26:26 Updated by Jan Skovgaard 15 Jul 2018, 12:34:03

Tags: Up For Grabs PR

Although membership login is not case sensitive the registration model forces lowercase characters. The model's username/email parameter is decorated with this?

[RegularExpression(@"[a-z0-9!#%&'*+/=?^_`{|}~-]+(?:\.[a-z0-9!#%&'+/=?^_`{|}~-]+)@(?:a-z0-9?.)+a-z0-9?", ErrorMessage = "Please enter a valid e-mail address")]

Is there any way it can be amended to include A-Z too? This would stop people complaining when they feel their email address should contain capital letters?

Many thanks.. I could make the change myself, but I'm not sure how to submit changes, or if you even want it?

Comments

Sebastiaan Janssen 10 Apr 2018, 11:54:38

Hey @dontbesorry80 ! Since you've already found the regex, make sure to update it and send a PR!

Our contribution documents should guide you on how to do this: https://github.com/umbraco/Umbraco-CMS/blob/dev-v7/CONTRIBUTING.md#how-do-i-even-begin

And if you have questions along the way maybe drop into the chat: https://gitter.im/umbraco/Umbraco-CMS


Robert Dyson 10 Apr 2018, 12:01:27

@sebastiaan Right. I'll give it a go and let you know in here when I've done it. I've always wanted to contribute ;)


Sebastiaan Janssen 10 Apr 2018, 12:29:49

Awesome!


Robert Dyson 13 Apr 2018, 10:22:26

@sebastiaan I tried to follow the instructions and checked in the change under a branch called UV-11198. Please let me know if there are any problems with how I've pushed it in ;)


Sebastiaan Janssen 13 Apr 2018, 12:04:42

@dontbesorry80 Hmm, I don't see it in the list here: https://github.com/umbraco/Umbraco-CMS/pulls

Maybe you haven't touched the "New pull request" button yet? ;-)


Robert Dyson 13 Apr 2018, 13:15:45

@sebastiaan

Thanks for the pointer:

https://github.com/umbraco/Umbraco-CMS/pull/2583

Rob


Priority: Normal

Type: Bug

State: Fixed

Assignee:

Difficulty: Normal

Category:

Backwards Compatible: True

Fix Submitted: Pull request

Affected versions:

Due in version: 7.12.0

Sprint:

Story Points:

Cycle: