U4-11222 - Merge infinite editing code to new v8 branch

Created by Shannon Deminick 16 Apr 2018, 09:54:29 Updated by Robert Copilau 18 Apr 2018, 12:51:46

Subtask of: U4-11218

We have a proof of concept branch with the infinite editing here: http://issues.umbraco.org/issue/U4-10934 which we need to merge into the v8 branch.

1 Attachments

Comments

Mads Rasmussen 17 Apr 2018, 08:04:12

The v7 infinite editing branch has been merged into a temp feature branch for the first infinite flow: The branch is this one: https://github.com/umbraco/Umbraco-CMS/tree/temp-U4-11218 which matches the swimlane task: http://issues.umbraco.org/issue/U4-11218

You can compare the branch with dev main v8 branch for easier overview of the changes: https://github.com/umbraco/Umbraco-CMS/compare/dev-v8...temp-U4-11218

For more info about implementation details see comment on this issue: http://issues.umbraco.org/issue/U4-10934

The test should include:

  • create a node with a media picker
  • upload a new image
  • click the edit button in the media picker to edit image directly.
  • Change something and save.
  • Select image.
  • click the edit button to edit picked media item directly from content node


Shannon Deminick 18 Apr 2018, 05:48:26

It's hard to know what anything is doing without some code comments:

  • editorService
  • umbEditor

Apart from that, I can see that the infinite editing panels open and the merge seems good, however editing a selected media item and removing and adding a new image, pressing Save and Close does save the image but the content editor isn't updated to display the new image thumbnail so it looks like nothing has changed.

I realize this task is more about the merging than the functionality so please feel free to close this particular task if these are planned to be addressed separately.


Robert Copilau 18 Apr 2018, 12:51:35

Also, you cannot edit the image unless the node has been saved, but as Shannon said, this is about the merge and not the functionality, I'll move it to fixed.


Priority: Normal

Type: Task

State: Fixed

Assignee:

Difficulty: Normal

Category:

Backwards Compatible: True

Fix Submitted:

Affected versions: 8.0.0

Due in version: 8.0.0

Sprint: Sprint 83

Story Points: 1

Cycle: