U4-11233 - Not clear what type "intro" does on tour step

Created by Dave Woestenborghs 17 Apr 2018, 10:46:34 Updated by Sebastiaan Janssen 28 Jun 2018, 18:18:52

Tags: PR

What did you do?

Added a tour step with type set to "intro" and also specified the element to be highlighted by mistake. Also specified a event element

What did you expect to happen? That step would be shown centered and no element would be highlighted

What actually happened? The step was shown near the element and the element was highlighted. The step showed a start tour button, making the set event element useless.

So i'm wondering if this is expected behavior ? I expected that a step specified as "intro" would always be shown as "centered".

Dave

1 Attachments

Download introstep.json

Comments

Dave Woestenborghs 17 Apr 2018, 10:47:32

I added an example tour to reproduce


Mads Rasmussen 17 Apr 2018, 19:00:14

It sounds like a bug to me. The idea with the intro step is to make the centered box you are talking about. I guess we miss some cancellation of the positioning when a step is set as an intro. The quick fix would be to remove the element.


Dave Woestenborghs 18 Apr 2018, 06:30:38

Added a PR : https://github.com/umbraco/Umbraco-CMS/pull/2592


Priority: Normal

Type: Usability Problem

State: Fixed

Assignee:

Difficulty: Normal

Category:

Backwards Compatible: True

Fix Submitted: Pull request

Affected versions: 7.8.0, 7.7.8, 7.9.0, 7.8.1, 7.10.0, 7.9.1, 7.9.2, 7.9.3, 7.10.1, 7.10.2, 7.9.4, 7.10.3, 7.8.2, 7.9.5

Due in version: 7.12.0

Sprint:

Story Points:

Cycle: