U4-11283 - Cannot save content when a doc type is variant but a property type is invariant

Created by Shannon Deminick 30 Apr 2018, 09:50:42 Updated by Claus Jensen 18 May 2018, 12:44:39

Subtask of: U4-11278

If you try this you'll get a YSOD

Comments

Robert Copilau 04 May 2018, 12:03:11

PR:https://github.com/umbraco/Umbraco-CMS/pull/2614

How to test: *Make sure you have more than one language added *Create an invariant doctype and add an invariant property *Check that you can create and save a content item based on the invariant doctype *Make the invariant doctype variant and fill out the variant names, note that the property remained invariant and should keep its value across all variants *Make the invariant property variant and add values for all the variants *Now play around with the doctype and property (switching between variant and invariant) and make sure that the values stay consistent based on being variant or invariant.


Stephan 08 May 2018, 09:21:47

reopening - that was fixed by ... when setting a property value for a culture, on something that is invariant, set the invariant culture value - but at a low level, this is magic and we don't want magic - setting a culture value on an invariant content should throw - now, if that causes a problem, need to understand where and fix there

also... for those hairy situations, we need to have a failing unit test so we can clearly see what's going on, before fixing

reopening, fixing


Stephan 08 May 2018, 14:00:07

dealing with it in U4-11282 branch


Shannon Deminick 10 May 2018, 13:29:38

Pretty sure this is all resolved now in latest code for http://issues.umbraco.org/issue/U4-11282


Claus Jensen 18 May 2018, 12:44:35

Confirmed that creating variant doctype with invariant property behaves as expected in the latest v8 code.


Priority: Normal

Type: Task

State: Fixed

Assignee:

Difficulty: Normal

Category:

Backwards Compatible: True

Fix Submitted:

Affected versions: 8.0.0

Due in version: 8.0.0

Sprint: Sprint 85

Story Points: 3

Cycle: 10