U4-11284 - When you don't have any doc types that are variant, the tree language drop downs should not be there

Created by Shannon Deminick 30 Apr 2018, 09:54:14 Updated by Robert Copilau 08 May 2018, 10:26:52

Subtask of: U4-11278

This will occur when:

  • You only have 1 language
  • You have 0 doc types that are variant

In this case, no language drop downs should be available.

OPTIONAL: you have 0 content items created based on variant doc types - if i create a content item that is variant, then the drop down needs to be displayed dynamically. Once the above are done, perhaps you might think this is easy, else create another task.

Comments

Robert Copilau 02 May 2018, 11:41:25

"You only have 1 language" - already done.


Robert Copilau 03 May 2018, 06:14:15

"You have 0 doc types that are variant" - done, looking at what OPTIONAL needs to be done.


Robert Copilau 03 May 2018, 08:36:01

PR:https://github.com/umbraco/Umbraco-CMS/pull/2612 does not contain option one, will create a new task for that. http://issues.umbraco.org/issue/U4-11299

How to test: *Make sure you have only one language, check if the language drop-down shows on the main tree (it should not), add more languages, check it is being rendered (it should) *With more than one language added, create a document type with "Allow invariant" on, make sure dropdown is there, go back and un-check "Allow variation", make sure dropdown goes away.

Note: [Fix for an unrelated issue has been included in the PR.|https://github.com/umbraco/Umbraco-CMS/pull/2612/commits/8a9caad23d8a55eddb1d54a33359933b41203c20] When a property editor has min max settings and they are undefined, in ConfigurationEditor.cs FromConfigurationEditor() it will try to remove those settings keys from a list that has not yet been populated.

To test to see if it works, try and add a Decimal or a Numeric property editor, it should not throw a "Collection was modified; enumeration operation may not execute." error.


Warren Buckley 08 May 2018, 09:28:26

All tested and code reads fine - merged in


Robert Copilau 08 May 2018, 10:26:52

Second PR has been created to address some issues: *When creating/deleting languages, the event listeners populates the language list with the updated one which makes the Language picker appear for a second then disappear when it should not appear at all, a check has been added to prevent this. *Useless horizontal and vertical scrollbars on the language, now removed.

PR:https://github.com/umbraco/Umbraco-CMS/pull/2618


Priority: Normal

Type: Task

State: Fixed

Assignee:

Difficulty: Normal

Category:

Backwards Compatible: True

Fix Submitted:

Affected versions: 8.0.0

Due in version: 8.0.0

Sprint: Sprint 84

Story Points: 1

Cycle: 10