U4-11341 - Content node tree collapse on random nodes level 3 or lower after upgrade to 7.10.4

Created by Aleksander 15 May 2018, 13:46:50 Updated by Sebastiaan Janssen 20 Jun 2018, 08:23:44

Is duplicated by: U4-11457

Relates to: U4-10995

After upgrading from umbraco 7.4.3 to 7.10.4 i have the issue that for some of the content nodes in my backoffice, if i click them, the whole tree structure will collapse. If i go to to the Info tab on the node, the first till it will say "Opps content is published but not in cache", if i save and publish, this error dissappears, but the tree structure still collapse.

I had the same issue on a site i upgraded from 6.X to 7.8.1, for that site some of the nodes could be fixed if i saved and republished. This is not possible for my current site.

Similar Issues that didn't provide fix: http://issues.umbraco.org/issue/U4-4870 http://issues.umbraco.org/issue/U4-8891

I suspect it's only an issue for old content nodes, as i haven't been able to reproduce the behavior by making new or copying the old nodes. That said, copying all affected nodes and figuring our where they are referenced is a road i'd rather avoid.

1 Attachments

Comments

Thomas Beckert 07 Jun 2018, 15:41:25

Is there a workarround for this issue? I have this problem as soon I have a user with a startnode deeper than Level one. The refreshing of the tree happens in the content and in the media section, as soon as you select a node.


Thomas Beckert 13 Jun 2018, 12:56:29

My customers start complaining about this issue. A workarround would really be great.


Aleksander 13 Jun 2018, 14:35:01

i had to remake the affected nodes, but for me it only happended for a few nodes after an upgrade. So if it's an issue that suddenly happens to existing nodes, then this workaround wont help you :\


Thomas Beckert 13 Jun 2018, 14:40:52

Hi, Aleksander, it happens on a complete new installation, as soon, as the Starting-Node of a user is below level one. So I guess it is a bug in the core, since the show the parent node in the tree, even if the user cannot access them.


Sebastiaan Janssen 19 Jun 2018, 12:49:44

Reverting the fix in http://issues.umbraco.org/issue/U4-10995 makes it better, but then we have duplicate trees again.


Ben Har 19 Jun 2018, 13:10:26

There's a video showing what @Thomas.Beckert has described here: https://www.youtube.com/watch?v=wRzoC4rlt_I&feature=youtu.be


Sebastiaan Janssen 19 Jun 2018, 14:06:48

This problem is caused by a "fix" we put in the tree which worked in U4-10995 because we had 2 trees. The fix was to change the path being sent to the tree. We thought that the path could only start with the user's start node, but now that we've removed the double tree and show the full tree with nodes grayed out that are not accessible, we have to leave the full path intact.

We can revert that path manipulation now as we know the full path will always be available, even though some parent nodes are not clickable.

Tested on multiple startnode levels (1, 2, 3) and with both the media and content tree.

PR: https://github.com/umbraco/Umbraco-CMS/pull/2707


Sebastiaan Janssen 19 Jun 2018, 14:09:18

I think you can manually fix current versions by going into ~/Umbraco/Js/umbraco.directives.js and removing this block:

_.each(startNodes, function (i) { var found = .find(args.path, function (p) { return String(p) === String(i); }); if (found) { args.path = args.path.splice(.indexOf(args.path, found)); } });

Make sure to update the version in ClientDependency.config after doing that to clear the browser caching of this js file.


Ben Har 19 Jun 2018, 14:17:49

I did exactly that as soon as you posted the fix to github and can confirm it works. in 7.11 the lines you need to comment out are 6672 - 6679.

Thanks you Sebastian


Thomas Beckert 19 Jun 2018, 14:40:35

Can confirm it too. You made my day, Sebastiaan. Thanks a lot!


Priority: Normal

Type: Bug

State: Fixed

Assignee:

Difficulty: Normal

Category: UI

Backwards Compatible: True

Fix Submitted:

Affected versions: 7.8.1, 7.10.4

Due in version: 7.11.1

Sprint:

Story Points:

Cycle: