U4-1136 - Class in MediaPickerDataType.cs wrongly named MemberPickerDataType

Created by Søren Reinke 03 Nov 2012, 20:27:06 Updated by Sebastiaan Janssen 15 May 2013, 11:07:00

I noticed that the class name in MediaPickerDataType.cs wrongly named MemberPickerDataType.

The wrongly named class problem also existed in V4.8

1 Attachments

Download 2889.patch

Comments

Søren Reinke 03 Nov 2012, 20:27:50

I have attached the patch file changing the name.

Hopefully I made the patch the correct way, my first try on using HG.


Sebastiaan Janssen 05 Nov 2012, 09:35:42

Well that's a bit silly of us! ;)

Unfortunately this is a public class so people might be using it in their API calls. Hopefully in 6.0.0 we can apply this patch.


Søren Reinke 05 Nov 2012, 12:51:21

Makes sense not to apply it at the moment, to prevent breaking existing code :-)


Søren Reinke 13 Feb 2013, 10:13:06

Hi Sebastiaan

Any idea when it will be implemented in V6?


Matt Brailsford 13 Feb 2013, 13:30:51

Can't you at least rename the class and make a derived class with the old name and mark that obsolete. At least it means any new work can use the correct name regardless of waiting to use v6 or not?

public class MediaPickerDataType

[Obsolete] public class MemberPickerDataType: MediaPickerDataType


Søren Reinke 13 Feb 2013, 19:00:27

Excellent idea Matt.


Søren Reinke 01 May 2013, 06:59:37

Sebastiaan, when will this be implemented, Matt's idea should fix it without breaking anything.


Sebastiaan Janssen 01 May 2013, 07:33:54

Fixed as suggested by Matt in changeset 39584fd5e42e


Søren Reinke 01 May 2013, 07:52:09

Excellent, thanks :)


Priority: Normal

Type: Bug

State: Fixed

Assignee:

Difficulty: Normal

Category:

Backwards Compatible: False

Fix Submitted: Patch

Affected versions:

Due in version: 6.0.6, 4.11.9

Sprint:

Story Points:

Cycle: