U4-11401 - Unique content naming isn't implemented for culture variants

Created by Shannon Deminick 01 Jun 2018, 03:15:34 Updated by Robert Copilau 04 Jun 2018, 13:14:21

Subtask of: U4-11279

Unique content naming isn't implemented for culture variants

Comments

Shannon Deminick 01 Jun 2018, 05:55:58

PR is here: https://github.com/umbraco/Umbraco-CMS/pull/2664

To test:

  • review code
  • ensure unit tests all pass
  • create 3 languages
  • create a root node with 3 domains, one for each language
  • create a child node called "child-(lang)" as the name for each variant (substituting (lang) for the language)
  • do the same again and you'll see that the name will be automatically changed to "child-(lang) (1)"
  • do the same again and you'll see that the name will be automatically changed to "child-(lang) (2)"

NOTE: We need to put a DB Index on the umbracoContentVersion.[current] column since this is a column that is constantly queried and sorted on. @zpqrtbnk let me know your thoughts on that and then we can make a task to get it done.


Robert Copilau 04 Jun 2018, 13:14:14

Test results:

  • review code - Looks good
  • ensure unit tests all pass - They do
  • create 3 languages - Done
  • create a root node with 3 domains, one for each language - Done
  • create a child node called "child-(lang)" as the name for each variant (substituting (lang) for the language) - Done
  • do the same again and you'll see that the name will be automatically changed to "child-(lang) (1)" - Yes
  • do the same again and you'll see that the name will be automatically changed to "child-(lang) (2)" - Yes

All looks good, merging.


Priority: Normal

Type: Task

State: Fixed

Assignee:

Difficulty: Normal

Category:

Backwards Compatible: True

Fix Submitted:

Affected versions:

Due in version:

Sprint: Sprint 86

Story Points: 1

Cycle: