U4-11429 - Clean Umbraco.Web.UmbracoHelper [v7]

Created by Andy Thompson 09 Jun 2018, 15:47:03 Updated by Sebastiaan Janssen 13 Jul 2018, 07:28:00

Tags: PR

Relates to: U4-11492

Relates to: U4-11509

Note: This covers the v7 version but v8's version can use the same care.

The Umbraco.Web.UmbracoHelper class is a little dusty so I've started cleaning it, a little at a time. I'll submit a series of small PRs for the v7 branch under this issue. If they are accepted I'll keep cleaning.

I've seen that the v8 version is already diverting from the v7 version so if these changes can't be merged to v8 I am happy to make similar changes to v8 and send PRs.

Comments

Andy Thompson 09 Jun 2018, 17:48:21

Submitted a PR: https://github.com/umbraco/Umbraco-CMS/pull/2680


Sebastiaan Janssen 18 Jun 2018, 20:18:18

Thanks @Mundairson - I'll keep this in progress for a while, when we're close to releasing the next version (7.12) we can close it.


Andy Thompson 18 Jun 2018, 21:46:37

Thank you, @sebastiaan :-) This is fun :-)


Sebastiaan Janssen 13 Jul 2018, 07:27:57

@Mundairson I'll close this one now, if you have more then just create a new issue, thanks again!


Priority: Minor

Type: Task

State: Fixed

Assignee:

Difficulty: Normal

Category: Architecture

Backwards Compatible: True

Fix Submitted: Pull request

Affected versions:

Due in version: 7.12.0

Sprint:

Story Points:

Cycle: