U4-11464 - Null reference error when you leave value type of Label property editor empty

Created by Natasha de Canha 21 Jun 2018, 12:11:59 Updated by Jan Skovgaard 30 Jul 2018, 10:05:04

Tags: Up For Grabs

What did you do? Added a Label property editor without choosing a value type from the dropdown list.

What did you expect to happen? To get an error message.

What actually happened? I got an null reference exception.

If you try and do the same to the slider property editor, you get an error message "Property has errors" at the given location.

7 Attachments

Comments

Sebastiaan Janssen 11 Jul 2018, 06:16:42

Oops. that seems like an oversight!

I've marked as "Up for grabs" so that you or someone else coming along could create a pull request for it.


Jan Skovgaard 15 Jul 2018, 15:02:34

Hmm I just had a quick look at this but I'm not able to reproduce. If I try to save my new label datatype without selecting a value type then I see an error notification pop-up. See the video here https://www.youtube.com/watch?v=1Lj8KznFfPw&feature=youtu.be

Are there other ways where this issue can be reproduced? - I tested in 7.11.1.


Natasha de Canha 16 Jul 2018, 06:19:14

@JanSkovgaard I think the difference is, that I created a label property from within a document type. See screenshots below.


Jan Skovgaard 16 Jul 2018, 07:35:28

@natasha.decanha Ah, yes got it now. I rarely create the datatypes in this flow myself. Old habits are hard to change I guess :) But thanks for clarifying how to reproduce.


Natasha de Canha 16 Jul 2018, 07:38:31

@JanSkovgaard Haha yes, that is exactly the reason my boss told me to report everything I come across, because i'm new to Umbraco I have a fresh look on things that all the advanced Umbraco users just overlook (;


Jan Skovgaard 28 Jul 2018, 17:15:25

@sebastiaan Do you know if there is a specific reason that this is not set to be a string by default? Thereby this issue would never occur and if one needs it to be something else then it's a matter of selecting one of the other options from the dropdown? Unless I overlook something I think this could be the solution?


Sebastiaan Janssen 30 Jul 2018, 08:52:14

@JanSkovgaard Good point! I am not even sure why we even have a choice between different types, but I guess that's a leftover from the past. If you could look at if we can easily make "String" the default then that would be a nice and simple change.


Priority: Normal

Type: Bug

State: Open

Assignee:

Difficulty: Easy

Category:

Backwards Compatible: True

Fix Submitted:

Affected versions: 7.11.1

Due in version:

Sprint:

Story Points:

Cycle: