We have moved to GitHub Issues
Created by Natasha de Canha 21 Jun 2018, 12:11:59 Updated by Jan Skovgaard 30 Jul 2018, 10:05:04Tags: Up For Grabs
What did you do? Added a Label property editor without choosing a value type from the dropdown list.
What did you expect to happen? To get an error message.
What actually happened? I got an null reference exception.
If you try and do the same to the slider property editor, you get an error message "Property has errors" at the given location.
Oops. that seems like an oversight!
I've marked as "Up for grabs" so that you or someone else coming along could create a pull request for it.
Hmm I just had a quick look at this but I'm not able to reproduce. If I try to save my new label datatype without selecting a value type then I see an error notification pop-up. See the video here https://www.youtube.com/watch?v=1Lj8KznFfPw&feature=youtu.be
Are there other ways where this issue can be reproduced? - I tested in 7.11.1.
@JanSkovgaard I think the difference is, that I created a label property from within a document type. See screenshots below.
@natasha.decanha Ah, yes got it now. I rarely create the datatypes in this flow myself. Old habits are hard to change I guess :) But thanks for clarifying how to reproduce.
@JanSkovgaard Haha yes, that is exactly the reason my boss told me to report everything I come across, because i'm new to Umbraco I have a fresh look on things that all the advanced Umbraco users just overlook (;
@sebastiaan Do you know if there is a specific reason that this is not set to be a string by default? Thereby this issue would never occur and if one needs it to be something else then it's a matter of selecting one of the other options from the dropdown? Unless I overlook something I think this could be the solution?
@JanSkovgaard Good point! I am not even sure why we even have a choice between different types, but I guess that's a leftover from the past. If you could look at if we can easily make "String" the default then that would be a nice and simple change.
Backwards Compatible: True
Affected versions: 7.11.1
Due in version: