U4-11468 - Color picker labels gets replaced by hex color codes

Created by Natasha de Canha 21 Jun 2018, 12:53:57 Updated by Jan Skovgaard 11 Jul 2018, 17:32:12

Tags: Up For Grabs

Subtask of: U4-11510

What did you do? Add a label for a color in the color picker property editor.

What did you expect to happen? For the color label that I have given to be saved.

What actually happened? The text of the label got replaced with the hex color code after I saved the property editor and went back to edit the color picker.

2 Attachments

Comments

Jan Skovgaard 23 Jun 2018, 08:39:45

This happens if the "Include labels" checkbox is not set - When it's set it does not happen. The color picker could use a big round of TLC since this behaviour is really confusing indeed :)


Natasha de Canha 25 Jun 2018, 07:19:00

@JanSkovgaard Oh thanks for this! I completely missed that. Maybe you can use this as a tip from a new Umbraco use (:


Sebastiaan Janssen 11 Jul 2018, 06:29:16

I've marked as "Up for grabs" so that you or someone else coming along could create a pull request for it.


Jan Skovgaard 11 Jul 2018, 07:01:01

@sebastiaan Would it be an idea to make a "Master" issue relating all approved color picker issues to the master? I remember seeing quite a few different issues reported about it. Just it's easier to get an overview of what has been reported if one decides to work on one or more issues and figure out it makes sense to hit two birds with one stone? :)


Sebastiaan Janssen 11 Jul 2018, 07:26:45

@JanSkovgaard Sure! I am not very aware of the issues but it would be great if you want to help to relate them all together. We don't really want a "grand" issue as it's much easier to work on small improvements instead of just making a humongous issue that seems to difficult to handle.


Jan Skovgaard 11 Jul 2018, 07:29:52

@sebastiaan Sure I'll have a look at it. No no, only intention is to make it so people can get an overview since maybe some issues overlap each other a bit and it makes sense to fix issue a and b together because they somehow correlate...does it make sense? :)


Sebastiaan Janssen 11 Jul 2018, 08:51:50

Makes total sense! :-) Thanks for the help!


Priority: Normal

Type: Bug

State: Open

Assignee:

Difficulty: Easy

Category:

Backwards Compatible: True

Fix Submitted:

Affected versions:

Due in version:

Sprint:

Story Points:

Cycle: